From 441bad69488b2ec8b513b416a81689fd298355ef Mon Sep 17 00:00:00 2001
From: Caryl Wyatt <carylw@hathitrust.org>
Date: Thu, 7 Aug 2025 14:15:21 -0400
Subject: [PATCH] remove unnecessary cookie parameters

- remove extra parameters from notification cookie setItem function
- remove date logic from HT.prefs.set since that's in
  cookies setItem now
- change setMonth to setDate in cookie setItem method
---
 src/js/lib/cookies.js       | 2 +-
 src/js/lib/notifications.js | 2 +-
 src/js/lib/utils.js         | 4 +---
 3 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/js/lib/cookies.js b/src/js/lib/cookies.js
index 5b06447..9cc9a93 100644
--- a/src/js/lib/cookies.js
+++ b/src/js/lib/cookies.js
@@ -36,7 +36,7 @@ export const docCookies = {
       return false;
     }
     var expires = new Date();
-    expires.setMonth(expires.getDate() + duration);
+    expires.setDate(expires.getDate() + duration);
 
     var sExpires = '; expires=' + expires.toUTCString();
     document.cookie =
diff --git a/src/js/lib/notifications.js b/src/js/lib/notifications.js
index 30a109a..fac10d2 100644
--- a/src/js/lib/notifications.js
+++ b/src/js/lib/notifications.js
@@ -51,7 +51,7 @@ export class NotificationsManager {
   }
 
   updateTimestamp() {
-    this.cookieJar.setItem('HT.notice', this.effectiveOn(), null, '/', HT.cookies_domain);
+    this.cookieJar.setItem('HT.notice', this.effectiveOn(), 90);
   }
 }
 
diff --git a/src/js/lib/utils.js b/src/js/lib/utils.js
index dce67a5..35087b1 100644
--- a/src/js/lib/utils.js
+++ b/src/js/lib/utils.js
@@ -92,9 +92,7 @@ function setupHTEnv() {
     var prefs = HT.prefs.get();
     prefs = mergeDeep(prefs, params);
     try {
-      var expires = new Date();
-      expires.setDate(expires.getDate() + 90);
-      cookies.setItem('HT.prefs', JSON.stringify(prefs), expires, '/', HT.cookies_domain, true);
+      cookies.setItem('HT.prefs', JSON.stringify(prefs), 90);
     } catch (e) {
       // noop
       console.log(e);