Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

110 add missing events #152

Merged
merged 14 commits into from May 17, 2022
Merged

110 add missing events #152

merged 14 commits into from May 17, 2022

Conversation

lirona
Copy link
Contributor

@lirona lirona commented May 10, 2022

No description provided.

@lirona lirona linked an issue May 10, 2022 that may be closed by this pull request
Copy link
Collaborator

@jellegerbrandy jellegerbrandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some remarks...

contracts/HATVaults.sol Outdated Show resolved Hide resolved
contracts/HATVaults.sol Outdated Show resolved Hide resolved
contracts/HATVaults.sol Outdated Show resolved Hide resolved
contracts/HATVaults.sol Outdated Show resolved Hide resolved
contracts/HATVaults.sol Outdated Show resolved Hide resolved
contracts/HATVaults.sol Outdated Show resolved Hide resolved
contracts/HATVaults.sol Outdated Show resolved Hide resolved
contracts/HATVaults.sol Outdated Show resolved Hide resolved
contracts/HATVaults.sol Outdated Show resolved Hide resolved
Copy link
Collaborator

@jellegerbrandy jellegerbrandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess if you address ben's comments it is good to go :)

@lirona
Copy link
Contributor Author

lirona commented May 14, 2022

thanks @ben-kaufman for reviewing my pr!
you guys haven't answered my comments though.. @jellegerbrandy

Copy link
Collaborator

@jellegerbrandy jellegerbrandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi liron, more requested changes

contracts/HATVaults.sol Show resolved Hide resolved
contracts/HATVaults.sol Outdated Show resolved Hide resolved
contracts/HATVaults.sol Outdated Show resolved Hide resolved
contracts/HATVaults.sol Show resolved Hide resolved
@jellegerbrandy jellegerbrandy merged commit 2e431ed into develop May 17, 2022
@jellegerbrandy jellegerbrandy deleted the 110-add-missing-events branch May 25, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing events in functions of hats contracts
3 participants