New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback from using this bundle with Symfony 4.0 (Flex) #380

Open
gabiudrescu opened this Issue Dec 3, 2017 · 9 comments

Comments

Projects
None yet
6 participants
@gabiudrescu

gabiudrescu commented Dec 3, 2017

I ran into the following problems:

  • I had to manually declare all these bundles in config/bundles.php:
    Hautelook\AliceBundle\HautelookAliceBundle::class => ['dev' => true, 'test' => true],
    Nelmio\Alice\Bridge\Symfony\NelmioAliceBundle::class => ['dev' => true, 'test' => true],
    Fidry\AliceDataFixtures\Bridge\Symfony\FidryAliceDataFixturesBundle::class => ['dev' => true, 'test' => true]

otherwise, flex kept complaining that FidryAliceDataFixturesBundle was not loaded - to be more specific, failed with this exception: https://github.com/hautelook/AliceBundle/blob/master/src/DependencyInjection/HautelookAliceExtension.php#L43

  • I had to change config/packages/dev/hautelook_alice.yml from:
# Read the documentation: https://github.com/hautelook/AliceBundle/blob/v1.4.1/README.md
hautelook_alice:
    db_drivers:
        orm: ~
#    locale: en_US
#    seed: 1
#    persist_once: false
#    loading_limit: 5

to

hautelook_alice:
    fixtures_path: 'fixtures' 
    root_dirs:
        - '%kernel.root_dir%'
        - '%kernel.project_dir%'
@gabiudrescu

This comment has been minimized.

Show comment
Hide comment
@gabiudrescu

gabiudrescu Dec 3, 2017

from what I can see, only 1.4 is supported, as per https://github.com/symfony/recipes-contrib/tree/master/hautelook/alice-bundle.

are you open for a PR on supporting later versions (2.0rc)?

gabiudrescu commented Dec 3, 2017

from what I can see, only 1.4 is supported, as per https://github.com/symfony/recipes-contrib/tree/master/hautelook/alice-bundle.

are you open for a PR on supporting later versions (2.0rc)?

@theofidry

This comment has been minimized.

Show comment
Hide comment
@theofidry

theofidry Dec 3, 2017

Collaborator

I think a flex recipe for 2.0 would be awesome.

Regarding your issue above it is a bit weird that you have to declare all the bundles if you require all of them at the same time, maybe there is more there and something could be fixed.

Regarding the config it's because there is BC breaks between 1.4 and 2.0.

Collaborator

theofidry commented Dec 3, 2017

I think a flex recipe for 2.0 would be awesome.

Regarding your issue above it is a bit weird that you have to declare all the bundles if you require all of them at the same time, maybe there is more there and something could be fixed.

Regarding the config it's because there is BC breaks between 1.4 and 2.0.

@Czacha

This comment has been minimized.

Show comment
Hide comment
@Czacha

Czacha Dec 19, 2017

I had the same issue in Symfony 4.
After debug of EnvDirectoryLocator i delete ORM directory (because I saw that paths generated by this class doesn't have ORM at the end) and it works nice.

hautelook_alice: fixtures_path: 'DataFixtures'

and now I have DataFixtures dir in src folder

Czacha commented Dec 19, 2017

I had the same issue in Symfony 4.
After debug of EnvDirectoryLocator i delete ORM directory (because I saw that paths generated by this class doesn't have ORM at the end) and it works nice.

hautelook_alice: fixtures_path: 'DataFixtures'

and now I have DataFixtures dir in src folder

@Nightbr

This comment has been minimized.

Show comment
Hide comment
@Nightbr

Nightbr Dec 21, 2017

Same problem here with Symfony Flex structure... I need to specify the path to DataFixtures...
bin/console fixtures:load --fixtures=src/DataFixtures/ORM/dev in order to find Fixtures

Nightbr commented Dec 21, 2017

Same problem here with Symfony Flex structure... I need to specify the path to DataFixtures...
bin/console fixtures:load --fixtures=src/DataFixtures/ORM/dev in order to find Fixtures

@theofidry

This comment has been minimized.

Show comment
Hide comment
@theofidry

theofidry Dec 21, 2017

Collaborator

The default path changed so you need to update it if you want to keep your fixtures in the same place.

Maybe a deprecation notice could be added in 1.x to help with the upgrade, but tbh I'm more concerned of the installation step for which a flex recipe would be welcomed

Collaborator

theofidry commented Dec 21, 2017

The default path changed so you need to update it if you want to keep your fixtures in the same place.

Maybe a deprecation notice could be added in 1.x to help with the upgrade, but tbh I'm more concerned of the installation step for which a flex recipe would be welcomed

@jmsche

This comment has been minimized.

Show comment
Hide comment
@jmsche

jmsche Jan 15, 2018

Hi, I'm making a PR on symfony/recipes-contrib#252 to create 2.0-related files.

Something that blocks the PR is the Doctrine Bundle requirement in the following file: https://github.com/hautelook/AliceBundle/blob/v2.0.0/src/DependencyInjection/HautelookAliceExtension.php#L48

So I'm wondering why the Doctrine bundle isn't (right now) a hard dependency?

jmsche commented Jan 15, 2018

Hi, I'm making a PR on symfony/recipes-contrib#252 to create 2.0-related files.

Something that blocks the PR is the Doctrine Bundle requirement in the following file: https://github.com/hautelook/AliceBundle/blob/v2.0.0/src/DependencyInjection/HautelookAliceExtension.php#L48

So I'm wondering why the Doctrine bundle isn't (right now) a hard dependency?

@theofidry

This comment has been minimized.

Show comment
Hide comment
@theofidry

theofidry Jan 15, 2018

Collaborator

Thanks very much for looking into this @jmsche.

It shouldn't, it's just that right now Hautelook is not working with it but it is decoupled enough to be able to work with Mongo DB or other.

Collaborator

theofidry commented Jan 15, 2018

Thanks very much for looking into this @jmsche.

It shouldn't, it's just that right now Hautelook is not working with it but it is decoupled enough to be able to work with Mongo DB or other.

@Nijusan

This comment has been minimized.

Show comment
Hide comment
@Nijusan

Nijusan Feb 7, 2018

Contributor

hi @theofidry , to get this issue forward, i created this PR: #391

maybe it helps and we can have a 2.0 recipes asap cause somehow its rly annoying replacing the old config :)

Contributor

Nijusan commented Feb 7, 2018

hi @theofidry , to get this issue forward, i created this PR: #391

maybe it helps and we can have a 2.0 recipes asap cause somehow its rly annoying replacing the old config :)

@theofidry

This comment has been minimized.

Show comment
Hide comment
@theofidry

theofidry Feb 7, 2018

Collaborator

Thanks for it @Nijusan, it's much appreciated :)

Collaborator

theofidry commented Feb 7, 2018

Thanks for it @Nijusan, it's much appreciated :)

theofidry added a commit to theofidry/recipes-contrib that referenced this issue Sep 18, 2018

theofidry added a commit to theofidry/recipes-contrib that referenced this issue Sep 18, 2018

theofidry added a commit to theofidry/recipes-contrib that referenced this issue Sep 18, 2018

theofidry added a commit to theofidry/recipes-contrib that referenced this issue Sep 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment