Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix issues with Google Apps domains #85

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
  1. Change to the logic for falling back to a proxy in the _resolveHostMeta function. Now works with Google Apps domains that returns an unexpected document with no providers in it.
  2. Change to the _verifyAssertionAgainstProvider function. Now trims the discovered OpenID provider endpoint and the provider endpoint in assertion response in the same way. Fixes an issues with Google Apps domains. (Could fix the issue by trimming neither but I assume the trim was previously introduced for a reason.)
@aogriffiths aogriffiths Fix issues with Google Apps domains
1. Change to the logic for falling back to a proxy in the _resolveHostMeta function. Now works with Google Apps domains that returns an unexpected document with no providers in it.
2. Change to the _verifyAssertionAgainstProvider function. Now trims the discovered OpenID provider endpoint and the provider endpoint in assertion response in the same way. Fixes an issues with Google Apps domains. (Could fix the issue by trimming neither but I assume the trim was previously introduced for a reason.)
d798cb4

Neither of the endpoints were stripped prior to your patch. I am very uncertain as to whether stripping query strings is the right approach here. The spec is also not too clear on this.

Owner

havard commented Nov 16, 2012

I find no need for query string stripping in either python-openid or DotNetOpenAuth. If you would be willing to research what they do that makes your scenario work and patch accordingly I would be much more happy. :)

Owner

havard commented Jan 6, 2013

We have cleared up the query string matching/stripping issues in #89.

Could you please make a separate patch containing the fix for falling back to a proxy in _resolveHostMeta?

Owner

havard commented Mar 28, 2013

No response here for three months, closing.

@havard havard closed this Mar 28, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment