Extra protections against unvalidated access to pricing_record #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilcoggins
reviewed
Jul 14, 2021
There was a problem hiding this comment.
All looks fine.
Although instead of all of the bespoke accessor functions, I would have simply used the [] operator (which already uses check_validation()) to access all of the exchange rates, and declared the member variables as private. Then, instead of pr.get_unused1() it would simply be pr["XUSD"] (or more likely pr[source]).
akildemir
pushed a commit
that referenced
this pull request
Jan 30, 2023
multisig: fix segfault restoring encrypted multisig seed
akildemir
pushed a commit
that referenced
this pull request
Jan 30, 2023
12e7c41 Merge pull request #5 from j-berman/restore-msig-encrypted-seed (Justin Berman) 848a0c0 Fix segfault restoring encrypted multisig seed (j-berman) 401f5d9 Require user ack multisig is experimental to restore (j-berman) fc8a5d6 multisig: fix #8537 seed restore (suggestions by @UkoeHB) (j-berman)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a slightly safer mechanism for getting pricing record values. Direct access to struct members is still possible for backwards-compatibility, but discouraged.
Few cases where the struct was passed as a const by-value were fixed.
Deduplicated code handling block 821428