New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About dashboard translating #22

Closed
sashiba042 opened this Issue Feb 16, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@sashiba042

sashiba042 commented Feb 16, 2017

Hi, my first post at github.

I was translating the dashboard step by step through your tutorial, but the dashboard always displayed in english.
Found out that there's a backslash at the end of each language name in the setting page(and in the database, of course, ex. 'english\', 'traditional_chinese\').
This might cause problem when Lang.php(hoosk\system\core\Lang.php) preg_match the string around line 110.
I currently change the match pattern from
preg_match('/^[a-z_-]+$/i', $idiom)
to
preg_match('/^[a-z_-]+(\\\\)*$/i', $idiom), and it works so far.
Thx for the great framework!

@havok89 havok89 closed this Mar 27, 2017

@havok89

This comment has been minimized.

Show comment
Hide comment
@havok89

havok89 Mar 27, 2017

Owner

Hey, I have removed the extra slash in the latest version.

Thanks for bringing it to my attention!

Owner

havok89 commented Mar 27, 2017

Hey, I have removed the extra slash in the latest version.

Thanks for bringing it to my attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment