From 36c77641f68f8fbe490ba8fc82bd862570da237e Mon Sep 17 00:00:00 2001 From: John Sanda Date: Fri, 25 May 2018 11:45:48 -0400 Subject: [PATCH] [HWKMETRICS-789] do not swallow exception --- .../core/service/tags/SimpleTagQueryParser.java | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/tags/SimpleTagQueryParser.java b/core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/tags/SimpleTagQueryParser.java index 518cc2cf8..dc3288eb9 100644 --- a/core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/tags/SimpleTagQueryParser.java +++ b/core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/tags/SimpleTagQueryParser.java @@ -565,18 +565,13 @@ private Func1 tagValueFilter(String regexp, int index) { private Func1, Boolean> tagValueFilter(String regexp, String tagName) { // If no such tagName -> no match return tMetric -> { - try { - String tagValue = tMetric.getTags().get(tagName); - if(tagValue != null) { - boolean positive = (!regexp.startsWith("!")); - Pattern p = PatternUtil.filterPattern(regexp); - return positive == p.matcher(tagValue).matches(); // XNOR - } - return false; - } catch (Exception e) { - logger.warn("tagValueFilter failed", e); - return false; + String tagValue = tMetric.getTags().get(tagName); + if(tagValue != null) { + boolean positive = (!regexp.startsWith("!")); + Pattern p = PatternUtil.filterPattern(regexp); + return positive == p.matcher(tagValue).matches(); // XNOR } + return false; }; }