tag metrics with pod labels #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmazzitelli
force-pushed
the
pod-labels
branch
3 times, most recently
from
349835d
to
b7a2ec1
Compare
jmazzitelli
force-pushed
the
pod-labels
branch
from
b7a2ec1
to
146618a
Compare
|
I talked to @stefannegrea last week and he indicated this is a feature that would be useful in order to query H-Metrics easier. |
|
@jmazzitelli, I created issue #141 for this update. |
|
not sure if we should put the new setting under "kubernetes" or under "collector" since under "collector" is where the other tags are defined - seems to make sense to put this under "collector" too since this also effectively defines what tags are going to be put on the metrics. |
…ince that is where the other custom tags are defined, too. This setting is ignored when not running in OpenShift.
jmazzitelli
force-pushed
the
pod-labels
branch
from
64ed71e
to
709742c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.