Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added :root option to better reflect the directory structure of the app #8

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants

In the spirit of Rails 3.1 future-proofing, I wanted to add an option so that if I have a SCSS file in /app/assets/stylesheets/foo.scss, that it would be compiled to /public/stylesheets/foo.css. The :root option accomplishes this.

Owner

hawx commented Jun 17, 2011

I don't know if that really does what you would expect from root, as I'd expect you to set root to . for the readme example to work. But it does seem much better than the current method of just going up one directory.

Owner

hawx commented Jun 17, 2011

I've made these changes http://github.com/hawx/guard-sass/compare/da613ad3599970204200…71370b99435a3805fc8d.

It now determines paths from the directory that guard was called from which is what should have been happening from the start.

I also added a :root option which allows you to say the directory the output is found from. Though now that paths are found from where guard was called I'm not sure there is any point as you could just set :output differently. I may remove this, before releasing?

So, does that solve the problem you had?

Essentially, what I want to be able to do is say "look in app/assets/stylesheets, and output to public/stylesheets, maintaining the directory structure in app/assets/stylesheets".

I was trying to get this gem to mimic the way guard-coffeescript works, and adding the :root option seemed to do the trick.

If your changes accomplish the same thing, then by all means remove mine :)

On Jun 17, 2011, at 3:21 AM, hawxreply@reply.github.com wrote:

I've made these changes http://github.com/hawx/guard-sass/compare/da613ad3599970204200…71370b99435a3805fc8d.

It now determines paths from the directory that guard was called from which is what should have been happening from the start.

I also added a :root option which allows you to say the directory the output is found from. Though now that paths are found from where guard was called I'm not sure there is any point as you could just set :output differently. I may remove this, before releasing?

So, does that solve the problem you had?

Reply to this email directly or view it on GitHub:
#8 (comment)

Owner

hawx commented Jun 17, 2011

I've pushed a new version (0.2.0), but without :root as since I've changed the way paths are calculated it was pointless. Also as a bonus there is a new guard-coffeescript style short notation!

@hawx hawx closed this Jun 17, 2011

Thanks. I appreciate it!

On Jun 17, 2011, at 11:24 AM, hawx wrote:

I've pushed a new version (0.2.0), but without :root as since I've changed the way paths are calculated it was pointless. Also as a bonus there is a new guard-coffeescript style short notation!

Reply to this email directly or view it on GitHub:
#8 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment