Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component parser error when binding #88

Closed
tokiop opened this issue Jan 20, 2017 · 3 comments
Closed

Component parser error when binding #88

tokiop opened this issue Jan 20, 2017 · 3 comments

Comments

@tokiop
Copy link

@tokiop tokiop commented Jan 20, 2017

Binding seems to crash compilation of ComponentParser under some conditions, not sure if it's an error on my side.

Expected Behavior

Compilation :)

Current Behavior

No compilation :'(

Possible Solution

Initializing _nextId in ComponentParser.hx allow compilation :

    private static var _nextId:Int = 0;

Steps to Reproduce

Using this component in ui.xml :

    <hbox>
        <label text="Slider:" />
        <hslider id="slider" min="1" max="200" value="5" />
        <label bindTo="slider" />
    </hbox>

Compilation fails with :

$ openfl test neko
../haxeui-core/haxe/ui/parsers/ui/ComponentParser.hx:54: characters 8-17 : +
../haxeui-core/haxe/ui/parsers/ui/XMLParser.hx:224: characters 31-55 : Called from
../haxeui-core/haxe/ui/parsers/ui/XMLParser.hx:50: characters 12-43 : Called from
../haxeui-core/haxe/ui/parsers/ui/XMLParser.hx:55: characters 20-69 : Called from
../haxeui-core/haxe/ui/parsers/ui/XMLParser.hx:55: characters 20-69 : Called from
../haxeui-core/haxe/ui/parsers/ui/XMLParser.hx:55: characters 20-69 : Called from
../haxeui-core/haxe/ui/parsers/ui/XMLParser.hx:21: characters 8-56 : Called from
../haxeui-core/haxe/ui/macros/ComponentMacros.hx:104: characters 30-132 : Called from
../haxeui-core/haxe/ui/macros/ComponentMacros.hx:40: characters 24-111 : Called from

Test app / minimal test case

component-parser-error.zip

Your Environment

  • git versions of haxeui-core and haxeui-openfl
  • haxe 3.2.1 and neko 2.0.0
  • Debian Stretch

Thanks for you work and dedication !

@ianharrigan
Copy link
Member

@ianharrigan ianharrigan commented Jan 31, 2017

Right, i see this make sense... _nextId is essentially null on neko...

@ianharrigan ianharrigan added the bug label Jan 31, 2017
ianharrigan added a commit that referenced this issue Feb 3, 2017
@ianharrigan
Copy link
Member

@ianharrigan ianharrigan commented Feb 3, 2017

Can we recheck this and close if all fine?

Thanks!

@tokiop
Copy link
Author

@tokiop tokiop commented Feb 3, 2017

Fix confirmed, thanks !

@tokiop tokiop closed this Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.