Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impove Parser card #1437

Merged
merged 1 commit into from Jun 26, 2022
Merged

Conversation

Miroito
Copy link
Contributor

@Miroito Miroito commented Jun 21, 2022

Changes

  • Moved the original text to a less awkward position since ingredient sections are now kept. See screenshots.

Before

image

After

image

@michael-genson
Copy link
Collaborator

Huh, when I added the data back in I didn't actually know the frontend rendered the titles here. I like this better

@hay-kot
Copy link
Collaborator

hay-kot commented Jun 21, 2022

Does this remove the display text if they're collapsed? Sometimes the % will be high and it will default to collapsed, but I still read through incase the sentence is structured weird and I know there will be problems.

@Miroito
Copy link
Contributor Author

Miroito commented Jun 25, 2022

Does this remove the display text if they're collapsed? Sometimes the % will be high and it will default to collapsed, but I still read through incase the sentence is structured weird and I know there will be problems.

I have added a fade in transition lines 53 to 57 to still show the original text. You can pull the branch to have a look at it if you like.

@hay-kot
Copy link
Collaborator

hay-kot commented Jun 25, 2022

I have added a fade in transition lines 53 to 57 to still show the original text. You can pull the branch to have a look at it if you like.

I'm apparently not so good at the reading comprehension. I will take a look at this tomorrow morning, thanks!

@hay-kot
Copy link
Collaborator

hay-kot commented Jun 26, 2022

Really dig the fade, thanks for this one! 🚀

@hay-kot hay-kot merged commit 151e204 into mealie-recipes:mealie-next Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants