Skip to content
This repository has been archived by the owner. It is now read-only.

undefined _guid error when using module.on in subclasses #29

Merged
merged 1 commit into from Feb 8, 2013

Conversation

@ericchaves
Copy link
Contributor

ericchaves commented Feb 6, 2013

Added a monkey patch to fix error when using events in subclasses.

var Parent = Stapes.subclass({});
var Module = Parent.subclass({ "sleep" : function() { this.emit('sleeping', 'very deep'); } });
var module = new Module();
module.on('sleeping', function(how) { console.log("i'm sleeping " + how); });

TypeError: 'undefined' is not an object (evaluating 'this._.guid')

when instantiating subclasses, the constructor relies on variable named includeEvents that is evaluated to false (due to clojure out of scope, I guess) and therefore does not properly add a _guid, making the use of events to thrown an error.

Cheers,

@Neogavin
Copy link

Neogavin commented Feb 8, 2013

Man, I just ran into this today and it was driving me crazy! Thanks for the fix.

hay added a commit that referenced this pull request Feb 8, 2013
undefined _guid error when using module.on in subclasses
@hay hay merged commit f79b934 into hay:master Feb 8, 2013
@hay
Copy link
Owner

hay commented Feb 8, 2013

Thanks! The code for createSubclass has become a bit hairy, so i didn't catch this. I'll add a test and add you to the contributions in the docs as well. Thanks again!

hay added a commit that referenced this pull request Feb 8, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.