This repository was archived by the owner on May 2, 2019. It is now read-only.
Fix for problem with unbinding events inside cb#30
Merged
Conversation
When doing something like this:
.on('evt', function theCallback(data){
this.off('evt', theCallback);
});
stapes will throw an error because the event handler array
is being modified as it is looping though.
This edit copies the array locally to fix this.
hay
added a commit
that referenced
this pull request
Feb 8, 2013
Fix for problem with unbinding events inside cb
Owner
|
Merged and will be in the next release. I've optimized the code a little bit ( |
Contributor
Author
|
Good call. (pun intended) |
Owner
|
Lol. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing something like this:
.on('evt', function theCallback(data){
this.off('evt', theCallback);
});
stapes will throw an error because the event handler array
is being modified as it is looping though.
This edit copies the array locally to fix this.