fix typo on extend function #33

Merged
merged 1 commit into from Feb 27, 2013

Projects

None yet

2 participants

@gonchuki
Contributor

So turns out I was checking out your library and found out this typo.

I'm wondering why nothing that uses the lib broke on your end as a git blame shown this change dates to Jan 11, but you might need some tests around this feature.

@hay hay merged commit 988b978 into hay:master Feb 27, 2013
@hay
Owner
hay commented Feb 27, 2013

Thanks for your PR. Actually, i just saw that wasn't the only problem, the extend method didn't extend the prototype of the module, so the function was essentially useless and broke all plugins. Apparently not a lot of people use plugins, so i guess that's why nobody noticed. Thanks again!

@hay hay added a commit that referenced this pull request Feb 27, 2013
@hay Fixing Stapes.extend (#33) 71914bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment