Skip to content
This repository has been archived by the owner. It is now read-only.

fix typo on extend function #33

Merged
merged 1 commit into from Feb 27, 2013
Merged

fix typo on extend function #33

merged 1 commit into from Feb 27, 2013

Conversation

@gonchuki
Copy link
Contributor

gonchuki commented Feb 21, 2013

So turns out I was checking out your library and found out this typo.

I'm wondering why nothing that uses the lib broke on your end as a git blame shown this change dates to Jan 11, but you might need some tests around this feature.

hay added a commit that referenced this pull request Feb 27, 2013
fix typo on extend function
@hay hay merged commit 988b978 into hay:master Feb 27, 2013
@hay
Copy link
Owner

hay commented Feb 27, 2013

Thanks for your PR. Actually, i just saw that wasn't the only problem, the extend method didn't extend the prototype of the module, so the function was essentially useless and broke all plugins. Apparently not a lot of people use plugins, so i guess that's why nobody noticed. Thanks again!

hay added a commit that referenced this pull request Feb 27, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.