New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo on extend function #33

Merged
merged 1 commit into from Feb 27, 2013

Conversation

Projects
None yet
2 participants
@gonchuki
Contributor

gonchuki commented Feb 21, 2013

So turns out I was checking out your library and found out this typo.

I'm wondering why nothing that uses the lib broke on your end as a git blame shown this change dates to Jan 11, but you might need some tests around this feature.

hay added a commit that referenced this pull request Feb 27, 2013

Merge pull request #33 from gonchuki/fix_typo
fix typo on extend function

@hay hay merged commit 988b978 into hay:master Feb 27, 2013

@hay

This comment has been minimized.

Show comment
Hide comment
@hay

hay Feb 27, 2013

Owner

Thanks for your PR. Actually, i just saw that wasn't the only problem, the extend method didn't extend the prototype of the module, so the function was essentially useless and broke all plugins. Apparently not a lot of people use plugins, so i guess that's why nobody noticed. Thanks again!

Owner

hay commented Feb 27, 2013

Thanks for your PR. Actually, i just saw that wasn't the only problem, the extend method didn't extend the prototype of the module, so the function was essentially useless and broke all plugins. Apparently not a lot of people use plugins, so i guess that's why nobody noticed. Thanks again!

hay added a commit that referenced this pull request Feb 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment