Make node types more strict #23

Merged
merged 5 commits into from Dec 3, 2016

Projects

None yet

3 participants

@haya14busa
Owner

No description provided.

@haya14busa haya14busa changed the title from Make node types more strict & and json arg to Make node types more strict and json arg Dec 3, 2016
@coveralls

Coverage Status

Coverage decreased (-0.9%) to 83.345% when pulling 3d907a5a32be77b1d2d16154fbbcec9b97d48e4f on sum-type into 47c0128 on master.

@coveralls

Coverage Status

Coverage decreased (-0.9%) to 83.345% when pulling 3d907a5a32be77b1d2d16154fbbcec9b97d48e4f on sum-type into 47c0128 on master.

added some commits Dec 3, 2016
@haya14busa make Expr sum type 8df930d
@haya14busa make Statement sum type 3827bd1
@haya14busa fix node exportation
feef606
@haya14busa haya14busa changed the title from Make node types more strict and json arg to Make node types more strict Dec 3, 2016
go/export.go
@@ -11,8 +11,8 @@ func (self *VimLParser) Parse(reader *StringReader, filename string) ast.Node {
return newAstNode(self.parse(reader), filename)
}
-func (self *ExprParser) Parse() ast.Node {
- return newAstNode(self.parse(), "")
+func (self *ExprParser) Parse() ast.Expr {
@reviewdog
reviewdog Dec 3, 2016

[golint] reported by reviewdog 🐶
receiver name should be a reflection of its identity; don't use generic names such as "this" or "self"

go/export.go
@@ -11,8 +11,8 @@ func (self *VimLParser) Parse(reader *StringReader, filename string) ast.Node {
return newAstNode(self.parse(reader), filename)
}
-func (self *ExprParser) Parse() ast.Node {
- return newAstNode(self.parse(), "")
+func (self *ExprParser) Parse() ast.Expr {
@reviewdog
reviewdog Dec 3, 2016

[golint] reported by reviewdog 🐶
exported method ExprParser.Parse should have comment or be unexported

ast/node.go
+func (*BasicLit) exprNode() {}
+func (*List) exprNode() {}
+func (*Dict) exprNode() {}
+func (*KeyValue) exprNode() {}
@reviewdog
reviewdog Dec 3, 2016

reported by reviewdog 🐶
func exprNode is unused (U1000)

ast/node.go
}
// ExCommand is the interface for Ex-command.
type ExCommand interface {
Node
Cmd() Cmd
+ stmtNode()
@reviewdog
reviewdog Dec 3, 2016

reported by reviewdog 🐶
func stmtNode is unused (U1000)

@coveralls

Coverage Status

Coverage decreased (-0.8%) to 83.345% when pulling feef606 on sum-type into 84056cc on master.

@coveralls

Coverage Status

Coverage decreased (-0.8%) to 83.345% when pulling feef606 on sum-type into 84056cc on master.

added some commits Dec 3, 2016
@haya14busa fix unused 4d6ec0f
@haya14busa add comment
253f161
@coveralls
coveralls commented Dec 3, 2016 edited

Coverage Status

Coverage decreased (-0.8%) to 83.363% when pulling 253f161 on sum-type into 84056cc on master.

@haya14busa haya14busa merged commit f57a807 into master Dec 3, 2016

3 of 4 checks passed

coverage/coveralls Coverage decreased (-0.8%) to 83.363%
Details
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@haya14busa haya14busa deleted the sum-type branch Dec 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment