New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce GitHub pull reviews api #63

Merged
merged 8 commits into from Dec 16, 2016

Conversation

Projects
None yet
3 participants
@haya14busa
Owner

haya14busa commented Dec 16, 2016

ref: #58

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 16, 2016

Current coverage is 79.36% (diff: 68.29%)

Merging #63 into master will decrease coverage by 0.41%

@@             master        #63   diff @@
==========================================
  Files            10         10          
  Lines           712        751    +39   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            568        596    +28   
- Misses          100        106     +6   
- Partials         44         49     +5   

Powered by Codecov. Last update cc1a3c8...70b3298

codecov-io commented Dec 16, 2016

Current coverage is 79.36% (diff: 68.29%)

Merging #63 into master will decrease coverage by 0.41%

@@             master        #63   diff @@
==========================================
  Files            10         10          
  Lines           712        751    +39   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            568        596    +28   
- Misses          100        106     +6   
- Partials         44         49     +5   

Powered by Codecov. Last update cc1a3c8...70b3298

Show outdated Hide outdated github.go
mediaTypePullRequestReview = "application/vnd.github.black-cat-preview+json"
)
type Review struct {

This comment has been minimized.

@reviewdog

reviewdog Dec 16, 2016

[golint] reported by reviewdog 🐶
exported type Review should have comment or be unexported

@reviewdog

reviewdog Dec 16, 2016

[golint] reported by reviewdog 🐶
exported type Review should have comment or be unexported

This comment has been minimized.

@haya14busa

haya14busa Dec 25, 2016

Owner

it's ok because this struct is temporary one and replace it with go-github implementation later.

@haya14busa

haya14busa Dec 25, 2016

Owner

it's ok because this struct is temporary one and replace it with go-github implementation later.

Show outdated Hide outdated github.go
Comments []*ReviewComment `json:"comments,omitempty"`
}
type ReviewComment struct {

This comment has been minimized.

@reviewdog

reviewdog Dec 16, 2016

[golint] reported by reviewdog 🐶
exported type ReviewComment should have comment or be unexported

@reviewdog

reviewdog Dec 16, 2016

[golint] reported by reviewdog 🐶
exported type ReviewComment should have comment or be unexported

haya14busa added some commits Dec 16, 2016

@haya14busa haya14busa merged commit 3568427 into master Dec 16, 2016

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 82.258%
Details

@haya14busa haya14busa deleted the github-pull-reviews-api branch Dec 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment