Introduce GitHub pull reviews api #63

Merged
merged 8 commits into from Dec 16, 2016

Projects

None yet

3 participants

@haya14busa
Owner

ref: #58

added some commits Dec 16, 2016
@haya14busa github: implement GitHub PullRequest Create Review API d5bf028
@haya14busa github: use GitHub Review API
b016b36
@codecov-io
codecov-io commented Dec 16, 2016 edited

Current coverage is 79.36% (diff: 68.29%)

Merging #63 into master will decrease coverage by 0.41%

@@             master        #63   diff @@
==========================================
  Files            10         10          
  Lines           712        751    +39   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            568        596    +28   
- Misses          100        106     +6   
- Partials         44         49     +5   

Powered by Codecov. Last update cc1a3c8...70b3298

added some commits Dec 16, 2016
@haya14busa github: add test for GitHub Review API
c1092ea
@haya14busa reviewdog: return BulkCommentService.Flash() error 5256edd
@haya14busa github: skip comment if no comments and lock Post() and Flash() 2851086
github.go
+ mediaTypePullRequestReview = "application/vnd.github.black-cat-preview+json"
+)
+
+type Review struct {
@reviewdog
reviewdog Dec 16, 2016

[golint] reported by reviewdog 🐶
exported type Review should have comment or be unexported

@haya14busa
haya14busa Dec 25, 2016 Owner

it's ok because this struct is temporary one and replace it with go-github implementation later.

github.go
+ Comments []*ReviewComment `json:"comments,omitempty"`
+}
+
+type ReviewComment struct {
@reviewdog
reviewdog Dec 16, 2016

[golint] reported by reviewdog 🐶
exported type ReviewComment should have comment or be unexported

added some commits Dec 16, 2016
@haya14busa droneio: update secure token
dccb529
@haya14busa github: add comments
88976cf
@haya14busa droneio: update secure token
6f70db2
@haya14busa haya14busa merged commit 3568427 into master Dec 16, 2016

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 82.258%
Details
@haya14busa haya14busa deleted the github-pull-reviews-api branch Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment