ConnectionManager::shutdown should not throw any exception and ClusterTest.testListenersWhenClusterDown fails #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverted the order of InvocationService shutdown and ConnectionManager shutdown in order to eliminate any unnecessary retries happening during client shutdown, and prevent these retries causing any exceptions. Note that InvocationService::shutdown is only setting a boolean flag. At Java client, there is a CleanResourcesTask which periodically performs the cleanup of invocations. We really need such a task implemented in the future.
sancar
approved these changes
Jun 19, 2017
Contributor
|
Test FAILed. |
Collaborator
Author
|
verify |
Contributor
|
Test PASSed. |
…ethod. Fix: Set the handler registration id correctly, previously we left it as unset (empty) which indirectly caused the removals of the registration to fail.
Contributor
|
Test FAILed. |
Collaborator
Author
|
verify |
Contributor
|
Test PASSed. |
…ycleService::isOpen instead. Also, suppressed some logs printed during shutdown. Updated the start sequence to start the InvocationService start before ConnectionManager start (currently InvocationService::start is no-op). Updated shutdown sequence to shutdown PartitionService before ConnectionManager.
Contributor
|
Test PASSed. |
ihsandemir
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevented ConnectionManager::shutdown to throw any exception.
Reverted the order of InvocationService shutdown and ConnectionManager shutdown in order to eliminate any unnecessary retries happening during client shutdown, and prevent these retries causing any exceptions. Note that InvocationService::shutdown is only setting a boolean flag.
At Java client, there is a CleanResourcesTask which periodically performs the cleanup of invocations. We really need such a task implemented in the future.
fixes #258