Added Support for reading and writing UTF-8 arrays #303
Conversation
mstier
changed the title
|
Hello mstier, Can you rebase and resubmit the PR? Can you also add a test for this so that we can merge it? Thanks for the PR. |
ihsandemir
left a comment
ihsandemir
left a comment
There was a problem hiding this comment.
Needs to be rebased.
|
Can one of the admins verify this patch? |
|
verify |
|
Hi @mstier , |
|
Linux test PASSed. |
|
Windows test PASSed. |
| #define HAZELCAST_CLIENT_SPI_DEFAULTOBJECTNAMESPACE_H_ | ||
|
|
||
| #include <string> | ||
| #include <functional> |
There was a problem hiding this comment.
As far as I remember, there was a compile error using the Visual Studio 2015 compiler under Windows without this include. Not sure if this is required anymore.
| } | ||
|
|
||
|
|
||
| std::auto_ptr<std::vector<std::string> > PortableReaderBase::readUTFArray(const char *fieldName) { |
|
Markus Stier seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Can one of the admins verify this patch? |
|
@mstier Are you still working on this PR? We need to add a test to verify the changes and also we need to rebase the PR, can you do them? |
|
Fix is merged by #596 |
5 participants
Added support for reading and writing UTF-8 arrays from C++ client. Aimed to enhance interoperability with Java clients.