Thread termination passed argument memory leak fix #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed to the thread should be freed before thread exits. The leak was detected using valgrind. fixes hazelcast#455
Contributor
|
Linux test FAILed. |
Contributor
|
Windows test PASSed. |
Contributor
|
Windows test FAILed. |
Contributor
|
Linux test PASSed. |
sancar
approved these changes
Oct 4, 2018
Contributor
|
Windows test FAILed. |
Contributor
|
Linux test FAILed. |
Contributor
|
Windows test FAILed. |
Contributor
|
Linux test FAILed. |
1 similar comment
Contributor
|
Linux test FAILed. |
Contributor
|
Windows test FAILed. |
ihsandemir
force-pushed
the
threadLeakFix
branch
from
7f8357e to
66bb040
Compare
sancar
approved these changes
Oct 4, 2018
Contributor
|
Windows test PASSed. |
Contributor
|
Linux test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for leaking memory on thread close. The void pointer argument passed to the thread should be freed before thread exits. The leak was detected using valgrind.
fixes #455
I tried using AbstractThread pointer instead of ThreadInfo struct when creating the thread but then it causes the following lifecycle problem: When the client is shutdown using the ShutdownTask, then when ShutdownTask::run finishes it is possible that HazelcastClientInstanceImpl is destructed and hence the Shutdown thread(AbstractThread type) should not touch any field of HazelcastInstanceImpl. But if we passed the thread pointer, then it will be destroyed and an illegal access will occur.