Skip to content

Conversation

@RikeVoltz
Copy link
Contributor

@RikeVoltz RikeVoltz commented May 7, 2020

fixes #589
fixes #590

@devOpsHazelcast
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@devOpsHazelcast
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Collaborator

@ihsandemir ihsandemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@ihsandemir
Copy link
Collaborator

verify

@devOpsHazelcast
Copy link
Contributor

Linux test FAILed.

@RikeVoltz
Copy link
Contributor Author

RikeVoltz commented May 8, 2020

There are some issues with compiling current version of master branch of hazelcast-cpp-client by gcc<10 and clang<9.0 - especially there - there is std::atomic<std::chrono::steady_clock::time_point> closedTime variable in Connection class, that doesn't initialized explicitly in the constructor of this class. It implies using default empty constructor that entails compile error (because atomic default empty constructor is noexcept and it obligates internal variable to have noexcept default empty constructor too) in gcc<10 (in 10.0 everything is ok) and clang<9.0 (in 9 everything is ok) (probably in new versions of compilers they made time_point constructor noexcept). It can be fixed by using mutexes instead of atomic variable or by other solutions, provided there. Maybe it entailed failed linux build. Should I commit fixes, create new issue, or is there some other problem in build?

@ihsandemir
Copy link
Collaborator

The failing tests at linux

AwsClientTest.testClientAwsMemberNonDefaultPortConfig
AwsClientTest.testClientAwsMemberWithSecurityGroupDefaultIamRole
AwsClientTest.testFipsEnabledAwsDiscovery

will be OK once we have the windows build machine up and running, we have a problem at AWS to make the windows up and running, otherwise the tests look as a pass.

@ihsandemir
Copy link
Collaborator

@RikeVoltz Regarding uninitialized closedTime, yes, we can set it to a some initial value less than or equal to the startTime and not print it if it is less equal to the start time. If this solves the compilation problem, then this would be preferable compared to mutex usage.

Please go ahead and open a new issue and submit a new PR for that as well.

Note: Test failure is not related to this and it is due to our windows build machine dependency in AWS tests and i am working to make that machine up and running again.

@ihsandemir
Copy link
Collaborator

verify

@devOpsHazelcast
Copy link
Contributor

Windows test FAILed.

@devOpsHazelcast
Copy link
Contributor

Linux test FAILed.

@ihsandemir
Copy link
Collaborator

verify

@devOpsHazelcast
Copy link
Contributor

Windows test PASSed.

@devOpsHazelcast
Copy link
Contributor

Linux test PASSed.

@ihsandemir ihsandemir merged commit d1b2ea4 into hazelcast:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing operator< for HazelcastJsonValue Missing default ctor for HazelcastJsonValue

3 participants