-
Notifications
You must be signed in to change notification settings - Fork 51
Added missing less operator for HazelcastJsonValue, fixed necessity of empty default constructor of HazelcastJsonValue #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…f empty default constructor of HazelcastJsonValue
…e same with PagingPredicate
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
ihsandemir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
|
verify |
|
Linux test FAILed. |
|
There are some issues with compiling current version of master branch of hazelcast-cpp-client by gcc<10 and clang<9.0 - especially there - there is |
|
The failing tests at linux will be OK once we have the windows build machine up and running, we have a problem at AWS to make the windows up and running, otherwise the tests look as a pass. |
|
@RikeVoltz Regarding uninitialized Please go ahead and open a new issue and submit a new PR for that as well. Note: Test failure is not related to this and it is due to our windows build machine dependency in AWS tests and i am working to make that machine up and running again. |
|
verify |
|
Windows test FAILed. |
|
Linux test FAILed. |
|
verify |
|
Windows test PASSed. |
|
Linux test PASSed. |
fixes #589
fixes #590