-
Notifications
You must be signed in to change notification settings - Fork 51
Implement write/readUTFArray methods for PortableWriter/PortableReader #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Whoops, my bad, I haven't seen already submitted PR, that fixes the same issue. Should I close this one in favor of #303? |
Hello @RikeVoltz I asked the other PR submitter to update the PR #303 (comment) If he responds, then he can continue and we can close this PR, otherwise we can merge you PR. |
|
verify |
|
Windows test FAILed. |
|
Linux test FAILed. |
|
Test failures: windows: |
|
verify |
|
Linux test PASSed. |
|
Windows test PASSed. |
|
Merging this PR since there is no response to #303 (comment). Closing the other PR. |
This PR closes #224