Added the HazelcastClient::version API.
#657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Linux test PASSed. |
Contributor
|
Windows test PASSed. |
Contributor
|
Linux test PASSed. |
Contributor
|
Windows test PASSed. |
sancar
previously approved these changes
Oct 26, 2020
yemreinci
reviewed
Oct 26, 2020
| * | ||
| * @return the version of the client | ||
| */ | ||
| static const constexpr boost::string_view &version() { |
Contributor
There was a problem hiding this comment.
constexpr already means const.
Suggested change
| static const constexpr boost::string_view &version() { | |
| static constexpr boost::string_view &version() { |
hazelcast/include/hazelcast/client/impl/HazelcastClientInstanceImpl.h
Outdated
Show resolved
Hide resolved
ihsandemir
force-pushed
the
versionAPI
branch
from
147638c to
9de8a27
Compare
sancar
approved these changes
Oct 27, 2020
Contributor
|
Linux test PASSed. |
Contributor
|
Windows test PASSed. |
yemreinci
approved these changes
Oct 27, 2020
Contributor
|
Linux test PASSed. |
Contributor
|
Windows test PASSed. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #612