Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api-427 Add paging predicate sample #1000

Merged
merged 8 commits into from Sep 2, 2021
Merged

Conversation

srknzl
Copy link
Member

@srknzl srknzl commented Aug 2, 2021

fixes #903

DOCUMENTATION.md Outdated Show resolved Hide resolved
DOCUMENTATION.md Outdated Show resolved Hide resolved
mdumandag
mdumandag previously approved these changes Aug 10, 2021
@srknzl srknzl changed the title Update paging predicate doc Add paging predicate sample Aug 10, 2021
@mdumandag mdumandag self-requested a review August 10, 2021 16:59
@mdumandag mdumandag dismissed their stale review August 10, 2021 17:00

new changes

@srknzl srknzl requested a review from mdumandag August 18, 2021 09:54
@@ -1,5 +1,5 @@
target/*
.idea/*
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed to avoid .idea folders inside code samples directory ( when opening a code sample in intellij it is created)

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #1000 (a98798e) into master (4ee9c5c) will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1000      +/-   ##
==========================================
- Coverage   92.58%   92.29%   -0.30%     
==========================================
  Files         432      432              
  Lines       16730    16730              
  Branches     1037     1037              
==========================================
- Hits        15490    15441      -49     
- Misses        974     1020      +46     
- Partials      266      269       +3     
Impacted Files Coverage Δ
src/network/ConnectionManager.ts 81.12% <0.00%> (-6.18%) ⬇️
src/nearcache/RepairingTask.ts 89.70% <0.00%> (-2.95%) ⬇️
src/config/ConfigBuilder.ts 93.95% <0.00%> (-2.85%) ⬇️
src/util/Util.ts 87.09% <0.00%> (-1.30%) ⬇️
src/core/HazelcastError.ts 65.36% <0.00%> (-1.12%) ⬇️
src/protocol/ErrorFactory.ts 64.96% <0.00%> (-0.73%) ⬇️
src/invocation/ClusterService.ts 93.61% <0.00%> (-0.71%) ⬇️
src/invocation/InvocationService.ts 95.50% <0.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ee9c5c...a98798e. Read the comment docs.

Copy link
Contributor

@mdumandag mdumandag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with minor comments

code_samples/paging_predicate_sample/README.md Outdated Show resolved Hide resolved
code_samples/paging_predicate_sample/README.md Outdated Show resolved Hide resolved
code_samples/paging_predicate_sample/hazelcast.xml Outdated Show resolved Hide resolved
@srknzl
Copy link
Member Author

srknzl commented Sep 1, 2021

verify

@srknzl srknzl merged commit 3376192 into hazelcast:master Sep 2, 2021
srknzl added a commit to srknzl/hazelcast-nodejs-client that referenced this pull request Sep 10, 2021
@srknzl srknzl changed the title Add paging predicate sample api-427 Add paging predicate sample Oct 1, 2021
harunalpak pushed a commit to harunalpak/hazelcast-nodejs-client that referenced this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding a link to this example in documentation
3 participants