server should not close clients when client only listens #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Python 2.7 Tests PASSed. |
Contributor
|
Python 3.7 Tests PASSed. |
mdumandag
force-pushed
the
fix-server-closes-listening-client
branch
2 times, most recently
from
cf59c55 to
6d59dc1
Compare
Contributor
|
Python 2.7 Tests PASSed. |
Contributor
|
Python 3.7 Tests PASSed. |
Contributor
|
Python 2.7 Tests PASSed. |
Contributor
|
Python 3.7 Tests PASSed. |
Contributor
|
Python 2.7 Tests FAILed. |
Contributor
|
Python 3.7 Tests FAILed. |
sancar
approved these changes
Aug 29, 2018
mdumandag
force-pushed
the
fix-server-closes-listening-client
branch
from
f4d987b to
583622c
Compare
Contributor
|
Python 2.7 Tests PASSed. |
Contributor
|
Python 3.7 Tests FAILed. |
mdumandag
force-pushed
the
fix-server-closes-listening-client
branch
from
583622c to
3fcb3a7
Compare
Contributor
|
Python 2.7 Tests PASSed. |
Contributor
|
Python 3.7 Tests PASSed. |
Contributor
|
Python 2.7 Tests PASSed. |
Contributor
|
Python 3.7 Tests PASSed. |
mdumandag
force-pushed
the
fix-server-closes-listening-client
branch
from
0d250ec to
da83b5a
Compare
Contributor
|
Python 2.7 Tests PASSed. |
Contributor
|
Python 3.7 Tests FAILed. |
mdumandag
force-pushed
the
fix-server-closes-listening-client
branch
from
da83b5a to
39af5d1
Compare
Contributor
|
Python 2.7 Tests PASSed. |
Contributor
|
Python 3.7 Tests PASSed. |
mdumandag
force-pushed
the
fix-server-closes-listening-client
branch
from
39af5d1 to
1c458c2
Compare
Contributor
|
Python 3.7 Tests PASSed. |
Contributor
|
Python 2.7 Tests PASSed. |
sancar
approved these changes
Sep 24, 2018
furkansenharputlu
approved these changes
Oct 1, 2018
mdumandag
force-pushed
the
fix-server-closes-listening-client
branch
from
1c458c2 to
d00fd8a
Compare
Contributor
|
Python 3.7 Tests PASSed. |
Contributor
|
Python 2.7 Tests PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client was not sending Ping to server when last read time is up-to-date. When server constantly pushes events to client, client does not send any ping to server. And consequently, server closes client because it does not send any ping. Client logic has changed so that it send pings if there is no outgoing packages recently, rather than looking at incoming packages.
fixes #108