Go over the default time values #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puzpuzpuz
approved these changes
Dec 10, 2020
- Validated the default time values with the Java client. We were sending -1 second for unset values, however the server was expecting -1 millisecond. - Updated some parameter names or docstrings to make them more clear. - Implemented support for max idle in map `put`, `put_transient`, `put_if_absent` and `set`. Also added some basic tests. - Made queue `add` to return `IllegalStateError` to make it more consistent with other clients.
mdumandag
force-pushed
the
default-time-values
branch
from
897e1d3 to
2adf1fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validated the default time values with the Java client. We were
sending -1 second for unset values, however the server
was expecting -1 millisecond.
Updated some parameter names or docstrings to make them more
clear.
Implemented support for max idle in map
put,put_transient,put_if_absentandset. Also added some basic tests.Made queue
addto returnIllegalStateErrorto make itmore consistent with other clients.
Closes #258