Skip to content

Conversation

@yuce
Copy link
Contributor

@yuce yuce commented Apr 26, 2022

This PR:

  • Removes read_XXX_default methods from CompactReader
  • Adds get_field_kind method to CompactReader
  • Adds NOT_AVAILABLE to FieldKind and renumbers that.
  • Updated tests and documentation
  • Fixes predicate checking in Map.addEntryListener

@alisengul53 alisengul53 reopened this Apr 26, 2022
@yuce yuce changed the title Removed compact read_XXX_default methods Removed compact read_XXX_default methods [API-1324] Apr 26, 2022
@yuce yuce added this to the 5.1 milestone Apr 26, 2022
@yuce yuce changed the title Removed compact read_XXX_default methods [API-1324] Removed compact read_XXX_default methods [API-1324] [API-1313] Apr 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2022

Codecov Report

Merging #550 (47c4c62) into master (bb2692c) will decrease coverage by 0.04%.
The diff coverage is 69.23%.

❗ Current head 47c4c62 differs from pull request most recent head 0243e0c. Consider uploading reports for the commit 0243e0c to get more accurate results

@@            Coverage Diff             @@
##           master     #550      +/-   ##
==========================================
- Coverage   96.46%   96.41%   -0.05%     
==========================================
  Files         354      354              
  Lines       20256    20181      -75     
==========================================
- Hits        19539    19458      -81     
- Misses        717      723       +6     
Impacted Files Coverage Δ
hazelcast/serialization/compact.py 99.06% <50.00%> (-0.34%) ⬇️
hazelcast/proxy/map.py 97.78% <100.00%> (ø)
hazelcast/serialization/api.py 100.00% <100.00%> (ø)
hazelcast/listener.py 90.21% <0.00%> (-1.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb2692c...0243e0c. Read the comment docs.

@yuce yuce requested review from srknzl and utku-caglayan April 26, 2022 11:11
Copy link

@utku-caglayan utku-caglayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

@yuce yuce requested review from srknzl and utku-caglayan April 26, 2022 12:36
@yuce yuce merged commit 6f380c4 into hazelcast:master Apr 26, 2022
@yuce yuce deleted the remove-compact-default branch April 26, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants