-
Notifications
You must be signed in to change notification settings - Fork 73
Removed compact read_XXX_default methods [API-1324] [API-1313] #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #550 +/- ##
==========================================
- Coverage 96.46% 96.41% -0.05%
==========================================
Files 354 354
Lines 20256 20181 -75
==========================================
- Hits 19539 19458 -81
- Misses 717 723 +6
Continue to review full report at Codecov.
|
utku-caglayan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments
This PR:
read_XXX_defaultmethods fromCompactReaderget_field_kindmethod toCompactReaderNOT_AVAILABLEtoFieldKindand renumbers that.Map.addEntryListener