Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper way of heap-data conversion #10249

Closed
ahmetmircik opened this issue Apr 6, 2017 · 5 comments
Closed

Proper way of heap-data conversion #10249

ahmetmircik opened this issue Apr 6, 2017 · 5 comments

Comments

@ahmetmircik
Copy link
Member

@ahmetmircik ahmetmircik commented Apr 6, 2017

Current workaround is ToHeapDataConverter : #10245

@mmedenjak
Copy link
Contributor

@mmedenjak mmedenjak commented Jul 10, 2017

@ahmetmircik there is now a method exposed in OS: InternalSerializationService#toData(java.lang.Object, com.hazelcast.nio.serialization.DataType). Can you use this?

@ahmetmircik
Copy link
Member Author

@ahmetmircik ahmetmircik commented Jul 11, 2017

@mmedenjak this issue was originally requested by @jerrinot but i'm ok with the new method InternalSerializationService#toData(java.lang.Object, com.hazelcast.nio.serialization.DataType

@mmedenjak
Copy link
Contributor

@mmedenjak mmedenjak commented Jul 11, 2017

I know there are some concerns as to how it should be exposed but this variant seems fine to me - at least as a start. Perhaps it could be even better but at least you don't need to subclass/override anything in EE, instantiate that EE class and inject it instead of the OS version...

@ahmetmircik
Copy link
Member Author

@ahmetmircik ahmetmircik commented Jul 11, 2017

@jerrinot wdyt, can we close this one?

@burakcelebi
Copy link
Member

@burakcelebi burakcelebi commented Jan 2, 2018

Closing with @jerrinot's confirmation.

@burakcelebi burakcelebi closed this Jan 2, 2018
@mmedenjak mmedenjak removed the To Triage label Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.