Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildInfo isEnterprise() does not work in 3.7.x #10740

Closed
martinfurmanski opened this issue Jun 12, 2017 · 4 comments
Closed

BuildInfo isEnterprise() does not work in 3.7.x #10740

martinfurmanski opened this issue Jun 12, 2017 · 4 comments

Comments

@martinfurmanski
Copy link

@martinfurmanski martinfurmanski commented Jun 12, 2017

Code:

com.hazelcast.instance.BuildInfoProvider.getBuildInfo().isEnterprise()

With:

<dependency>
    <groupId>com.hazelcast</groupId>
    <artifactId>hazelcast-enterprise-all</artifactId>
    <version>3.7.8</version>
</dependency>

Expected: true
Returns: false

tested 3.7.5 and 3.7.8: broken
tested 3.8.2: works fine

I did some investigations and the hazelcast-runtime.properties resource embedded in the enterprise distribution simply has:

hazelcast.version = 3.7.5
hazelcast.build = 20170124
hazelcast.distribution = Hazelcast
hazelcast.git.revision = 111f332
hazelcast.serialization.version = 1

which seems to be the root of the problem.

@Donnerbart Donnerbart added this to the 3.7.8 milestone Jun 12, 2017
@martinfurmanski
Copy link
Author

@martinfurmanski martinfurmanski commented Jun 13, 2017

The reason I need this is because HZ will silently fail and revert to non-secure communication even if I configure/enable SSL but happen to run with the wrong dependencies. This is by itself quite bad, but being able to detect Enterprise at least gives me a chance to fail rather than continue on in a non-secure way.

@Donnerbart Donnerbart modified the milestones: 3.9, 3.7.8 Aug 18, 2017
@Donnerbart
Copy link
Contributor

@Donnerbart Donnerbart commented Aug 18, 2017

The BuildInfo generation was refactored in Hazelcast 3.9, see #10139

There is also a check if security is enabled and Hazelcast is not running with EE now: #11143

@Donnerbart Donnerbart closed this Aug 18, 2017
@martinfurmanski
Copy link
Author

@martinfurmanski martinfurmanski commented Aug 18, 2017

@Donnerbart fix in 3.7? it is broken there

@Donnerbart
Copy link
Contributor

@Donnerbart Donnerbart commented Aug 21, 2017

I don't think that we can backport all things to the 3.7.x line, our current maintenance version is 3.8.x. Since the BuildInfo refactoring was part of a big PR, it's best to ask @jerrinot about this. The Security check should be easier to backport @pveentjer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.