Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSGi] Hazelcast declares commons-logging as a required dependency but it is not required #10770

Closed
netudima opened this issue Jun 15, 2017 · 5 comments

Comments

@netudima
Copy link
Contributor

@netudima netudima commented Jun 15, 2017

Caused by: org.osgi.framework.BundleException: Unresolved constraint in bundle com.hazelcast [315]: Unable to resolve 315.0: missing requirement [315.0] osgi.wiring.package; (&(osgi.wiring.package=org.apache.commons.logging)(version>=1.2.0)(!(version>=2.0.0)))
at org.apache.felix.framework.Felix.resolveBundleRevision(Felix.java:4097)[org.apache.felix.framework-4.6.1.jar:]
at org.apache.felix.framework.Felix.startBundle(Felix.java:2114)[org.apache.felix.framework-4.6.1.jar:]
at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:977)[org.apache.felix.framework-4.6.1.jar:]

https://github.com/hazelcast/hazelcast/blob/master/hazelcast/pom.xml#L125 - need to add:
org.apache.commons.logging;resolution:=optional,

@jerrinot
Copy link
Contributor

@jerrinot jerrinot commented Jun 16, 2017

@netudima:

good catch, thanks a lot for your report.

@mdogan
Copy link
Contributor

@mdogan mdogan commented Jun 19, 2017

@netudima:
As far as I see only hazelcast-spring module declares commons-logging as a dependency. From output of mvn dependency:tree:

[INFO] +- org.springframework:spring-context:jar:4.3.0.RELEASE:provided
[INFO] |  +- org.springframework:spring-aop:jar:4.3.0.RELEASE:provided
[INFO] |  +- org.springframework:spring-beans:jar:4.3.0.RELEASE:provided
[INFO] |  +- org.springframework:spring-core:jar:4.3.0.RELEASE:provided
[INFO] |  |  \- commons-logging:commons-logging:jar:1.2:provided
[INFO] |  \- org.springframework:spring-expression:jar:4.3.0.RELEASE:provided
@netudima
Copy link
Contributor Author

@netudima netudima commented Jun 19, 2017

Yes, you are right. I rechecked manifests for JARs and the following ones only have the OSGi import (org.apache.commons.logging):

  • hazelcast-spring
  • hazelcast-all
@netudima
Copy link
Contributor Author

@netudima netudima commented Jun 19, 2017

Updated pull request to change manifests only for the mentioned JARs.

@mdogan
Copy link
Contributor

@mdogan mdogan commented Jul 10, 2017

fixed by #10771

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants