Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapProxyImpl.executeOnKeys broken when ConcurrentSkipListSet is passed #10877

Closed
gulzarsingh12 opened this issue Jul 5, 2017 · 2 comments
Closed

Comments

@gulzarsingh12
Copy link

@gulzarsingh12 gulzarsingh12 commented Jul 5, 2017

It throws NullPointerException when underlying Set implementation is ConcurrentSkipListSet.

public Map<K, Object> executeOnKeys(Set keys, EntryProcessor entryProcessor) {
if(keys != null && !keys.contains((Object)null)) {

contains() implementation is different in ConcurrentSkipListSet from HashSet.

private V doGet(Object key) {
if (key == null)
throw new NullPointerException();

so the check in MapProxyImpl !keys.contains((Object)null) would always throw a NPE.

@ahmetmircik ahmetmircik added this to the 3.8.4 milestone Jul 5, 2017
@ahmetmircik
Copy link
Member

@ahmetmircik ahmetmircik commented Jul 5, 2017

Thanks for reporting this.

@ahmetmircik
Copy link
Member

@ahmetmircik ahmetmircik commented Jul 10, 2017

fixed by #10884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.