Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider logging new HTTP connections with DEBUG or lower level #10924

Closed
dannygu opened this issue Jul 13, 2017 · 6 comments
Closed

Consider logging new HTTP connections with DEBUG or lower level #10924

dannygu opened this issue Jul 13, 2017 · 6 comments

Comments

@dannygu
Copy link

@dannygu dannygu commented Jul 13, 2017

Hi,

I've enabled the following in hazelcast.xml
<property name="hazelcast.http.healthcheck.enabled">true</property>

I've setup Consul to check health of the HC service every 30 seconds by http://X:5701/hazelcast/health, now I get the following 'error'/'info' in the HC log every 30 seconds

13-Jul-2017 21:00:28.016 INFO [hz._hzInstance_1_docker_int.IO.thread-Acceptor] com.hazelcast.nio.tcp.SocketAcceptorThread.null [10.0.2.71]:33334 [docker_int] [3.8.3] Accepting socket connection from /10.0.1.160:41488
13-Jul-2017 21:00:28.016 INFO [hz._hzInstance_1_docker_int.cached.thread-3] com.hazelcast.nio.tcp.TcpIpConnectionManager.null [10.0.2.71]:33334 [docker_int] [3.8.3] Established socket connection between /172.17.0.2:5701 and /10.0.1.160:41488
13-Jul-2017 21:00:28.017 INFO [hz._hzInstance_1_docker_int.IO.thread-in-1] com.hazelcast.nio.tcp.TcpIpConnection.null [10.0.2.71]:33334 [docker_int] [3.8.3] Connection[id=32, /172.17.0.2:5701->/10.0.1.160:41488, endpoint=null, alive=false, type=REST_CLIENT] closed. Reason: Connection closed by the other side

Is there any way to turn this off without turning off the entire log ?

Thanks!

@mmedenjak
Copy link
Contributor

@mmedenjak mmedenjak commented Jul 14, 2017

Hi @dannygu! I don't think it will be possible to turn it off the connection information per-IP address. But you can configure your logging framework to log at WARN level for these classes :
com.hazelcast.nio.tcp.SocketAcceptorThread
com.hazelcast.nio.tcp.TcpIpConnectionManager
com.hazelcast.nio.tcp.TcpIpConnection
Unfortunately that also means that you won't be able to see connection lifecycle information on client and members.

@dannygu
Copy link
Author

@dannygu dannygu commented Jul 15, 2017

Hi @mmedenjak , thanks for the answer.

This is what i was trying to avoid, turning off logging completely isn't very wise.

IMHO this is a bug /health shouldn't generate errors in the log as we aren't trying to initiate a new cluster connection/member.

Thanks!

@mmedenjak
Copy link
Contributor

@mmedenjak mmedenjak commented Jul 15, 2017

The logs are at INFO level, not ERROR. So you could raise the log level for just those three classes and still see any errors.

@rbalabomm
Copy link

@rbalabomm rbalabomm commented Sep 26, 2017

Hi Guys,

our team is facing same issue! is the issue resolved?

@mmedenjak mmedenjak added this to the 3.9.1 milestone Sep 27, 2017
@mmedenjak mmedenjak changed the title Hazelcast 3.8 HTTP Health Log Consider logging new HTTP connections with DEBUG or lower level Sep 27, 2017
@mmedenjak
Copy link
Contributor

@mmedenjak mmedenjak commented Sep 27, 2017

@rbalabomm the enhancement has not been addressed. You can increase the log level for that class in your logging configuration for now.

@Holmistr
Copy link
Collaborator

@Holmistr Holmistr commented Feb 2, 2018

We decided that we're not going to address this issue. We agree with the point in #11196 (comment) comment and we see it the way that users can always configure their logger appropriately. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.