Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST URLs for cluster version #11139

Closed
neilstevenson opened this issue Aug 18, 2017 · 4 comments
Closed

REST URLs for cluster version #11139

neilstevenson opened this issue Aug 18, 2017 · 4 comments

Comments

@neilstevenson
Copy link
Contributor

@neilstevenson neilstevenson commented Aug 18, 2017

https://github.com/hazelcast/hazelcast/blob/master/hazelcast/src/main/java/com/hazelcast/internal/ascii/rest/HttpGetCommandProcessor.java
will do the same thing for
http://127.0.0.1:5701/hazelcast/rest/cluster/version
and
http://127.0.0.1:5701/hazelcast/rest/cluster/state

As it's testing
} else if (uri.startsWith(URI_CLUSTER)) { on line 48
before
} else if (uri.startsWith(URI_CLUSTER_VERSION_URL)) { on line 52

Tried on 3-9-SNAPSHOT

@vbekiaris
Copy link
Contributor

@vbekiaris vbekiaris commented Aug 18, 2017

URI_CLUSTER_VERSION_URL is /hazelcast/rest/management/cluster/version so there is no overlap with URI_CLUSTER = "/hazelcast/rest/cluster". Is the cluster version management URL documented as /hazelcast/rest/cluster/version? Maybe we need to update docs.

@gokhanoner
Copy link
Contributor

@gokhanoner gokhanoner commented Aug 18, 2017

@vbekiaris it's not documented anywhere. We need to add all those links to documentation clearly, with example outputs and everything.

@neilstevenson
Copy link
Contributor Author

@neilstevenson neilstevenson commented Aug 18, 2017

@vbekiaris Putting all the links in the documentation would work for me, be enough to see this closed.

I'd misinterpreted the code, so HttpGetCommandProcessor isn't wrong, but it's difficult to folk (for me :-) ) so documentation for 3.9 would be good.

@vbekiaris
Copy link
Contributor

@vbekiaris vbekiaris commented Aug 21, 2017

Here is the documentation PR: hazelcast/hazelcast-reference-manual#310

@vbekiaris vbekiaris added this to the 3.9 milestone Aug 21, 2017
@mdogan mdogan closed this Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.