Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoveOperation returns old value, causes SerializationException in WanReplication when sources not available & store type is binary #11157

Closed
gokhanoner opened this issue Aug 19, 2017 · 1 comment

Comments

@gokhanoner
Copy link
Contributor

@gokhanoner gokhanoner commented Aug 19, 2017

Please see: https://github.com/hazelcast/hazelcast-enterprise/issues/1636

Other than com.hazelcast.map.impl.operation.RemoveOperation, all other remove operations (RemoveIfSameOperation, DeleteOperation, TryRemoveOperation, TxnDeleteOperation) return boolean status, instead of oldValue. Since Removed event raised inside the RemoveOperation, if that result is not used, we can simply return boolen status as well, which is already there.

@gokhanoner gokhanoner added this to the 3.8.5 milestone Aug 19, 2017
@gokhanoner
Copy link
Contributor Author

@gokhanoner gokhanoner commented Aug 20, 2017

Closing since return of the old value needed as contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants