Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Hazelcast 3.8.4 source code does not match the jar classes #11261
We are having a problem with the sources of the Hazelcast 3.8.4 release.
We downloaded both the jar and the sources from the mavel central repository:
An example of such mismatch is the package: com/hazelcast/cache/impl/maxsize/impl.
It seems the issue comes from the shaded hazelcast-client-protocol that contains the Hazelcast sources from a different version.
Would it be possible to check this?
I can confirm this and I think your analysis is spot on. I just checked our upcoming 3.8.5 release and it suffers from the same issue.
The root cause will be, that the client protocol project relies on some Hazelcast classes. So it fetches a (custom) branch to build the protocol JAR. And that JAR is again needed to build Hazelcast. It's an unfortunate circle dependency.
I'm having a look how to solve this at least for a release situation, so the source code matches.
We found out that the solution was quite simple :) The Hazelcast client protocol project was missing a configuration for the Maven source and JavaDoc plugins.
The fix will be in the next 1.4.2 and 1.5.0 releases of the Hazelcast client protocol. Since the issue is not critical, we won't stop our release verification process for 3.8.5 though (some long running release tests are already started). So this issue will eventually be fixed in Hazelcast 3.8.6 and 3.9.
Sorry for the inconvenience and thanks again for the report!