New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance regression in BaseIndexStore #11280
Comments
The regression is caused by this correctness fix: |
Will be addressed in 3.8.7 and 3.9.1 |
Thanks @tombujok, |
QueryBounceTest is to test query with and without index while bouncing members. So, it tests effects of member shutdown/restart and partition migrations. IndexSplitBrainTest is to test indexed query during network partition. |
Fixed via #11705 The fixes enables the users to choose: performance vs. correctness. Will be released in 3.8.7, 3.9.1 & 3.10 |
Hi @tombujok, |
Current implementation of BaseIndexStore.copyToMultiResultSet(..) is:
is it really necessary to create a new Map here? I see a serious bottleneck in this line. After changing it to:
I see performance improve in ~2.5 times on range queries over indexed attribute. All tests are still passed, and I don't see any issues in HZ behaviour.
Please have a look.
Thanks, Denis.
The text was updated successfully, but these errors were encountered: