Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultRecordStore#replace methods should load from MapLoader when key not found in storage #11300

Closed
hbrands opened this issue Sep 5, 2017 · 3 comments · Fixed by #14797
Closed

Comments

@hbrands
Copy link

@hbrands hbrands commented Sep 5, 2017

DefaultRecordStore#replace(Data key, Object update)
and
DefaultRecordStore#replace(Data key, Object expect, Object update)

look for the current record in the storage only.
If not found in the Storage, they should ask the MapStore (if available) via MapLoader#load(Data key) to load the data into memory from the store.

This would be consistent with other methods like
#remove(Data key)
#remove(Data key, Object testValue)
#put(Data key, Object value, long ttl)
#putIfAbsent(Data key, Object value, long ttl)

See also forum question here:
https://groups.google.com/forum/#!topic/hazelcast/-_beV0VY7Ms

@hbrands

This comment has been minimized.

Copy link
Author

@hbrands hbrands commented Sep 14, 2017

Well, I would consider this a defect, not an enhancement, but that's my personal opinion ;-)

@mmedenjak

This comment has been minimized.

Copy link
Contributor

@mmedenjak mmedenjak commented Sep 14, 2017

@hbrands might be. I'll remove that tag for now, it will probably get set by the developer working on it.

@mmedenjak

This comment has been minimized.

Copy link
Contributor

@mmedenjak mmedenjak commented Oct 3, 2017

@ahmetmircik do you think this is easy enough to add in 3.9 or will we push this to 3.9.1?

@mmedenjak mmedenjak removed the To Triage label Jan 29, 2018
@mmedenjak mmedenjak modified the milestones: 3.11, 3.12 Aug 28, 2018
@mmedenjak mmedenjak removed this from the 3.12 milestone Feb 25, 2019
@mustafaiman mustafaiman self-assigned this Mar 28, 2019
mustafaiman added a commit to mustafaiman/hazelcast that referenced this issue Mar 28, 2019
replace operation just overlooked MapLoader when given key is not present in-memory. Instead, it should try to load from MapLoader first.

fixes hazelcast#11300
mustafaiman added a commit to mustafaiman/hazelcast that referenced this issue Apr 3, 2019
replace operation just overlooked MapLoader when given key is not present in-memory. Instead, it should try to load from MapLoader first.

fixes hazelcast#11300
mustafaiman added a commit to mustafaiman/hazelcast that referenced this issue Apr 5, 2019
replace operation just overlooked MapLoader when given key is not present in-memory. Instead, it should try to load from MapLoader first.

fixes hazelcast#11300
mustafaiman added a commit to mustafaiman/hazelcast that referenced this issue Apr 5, 2019
replace operation just overlooked MapLoader when given key is not present in-memory. Instead, it should try to load from MapLoader first.

fixes hazelcast#11300
mustafaiman added a commit that referenced this issue Apr 5, 2019
replace operation just overlooked MapLoader when given key is not present in-memory. Instead, it should try to load from MapLoader first.

fixes #11300
@mmedenjak mmedenjak added this to the 4.0 milestone Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.