Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[operation] NPE when response and no response handler #11375

Closed
ahmetmircik opened this issue Sep 15, 2017 · 2 comments
Closed

[operation] NPE when response and no response handler #11375

ahmetmircik opened this issue Sep 15, 2017 · 2 comments

Comments

@ahmetmircik
Copy link
Member

@ahmetmircik ahmetmircik commented Sep 15, 2017

if i use execute to call an operation and if it times out, here operation cannot send response because responseHandler is null (assuming caller didn't set it initially). And it leads NPE.

@ahmetmircik ahmetmircik added this to the 3.8.6 milestone Sep 15, 2017
@pveentjer
Copy link
Member

@pveentjer pveentjer commented Sep 15, 2017

This only leads to problems for operations that are not following the path of a regular invocation since then an a response handler will be set. So only one that is executed using operationservice.execute(op) can lead to a NPE.

Also this is a benign issue since the NPE will be caught and logged. And caller of the operation didn't care for a response since the operation has nobody to send a response to.

@pveentjer
Copy link
Member

@pveentjer pveentjer commented Sep 22, 2017

Making this a 3.9 issue. The error is benign since the execution of the operation is wrapped in a try/catch so on the OperationThread level; so you get a logged stacktrace in any case.

So I don't see a good reason to backport; especially since I don't know of occurrences in the wild.

@pveentjer pveentjer changed the title NPE on operation call timeout [operation] NPE on operation call timeout Sep 22, 2017
@pveentjer pveentjer changed the title [operation] NPE on operation call timeout [operation] NPE when response and no response handler set. Sep 22, 2017
@pveentjer pveentjer changed the title [operation] NPE when response and no response handler set. [operation] NPE when response and no response handler Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.