Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lock] add logging to ILock operations #11622

Closed
vertex-github opened this issue Oct 18, 2017 · 2 comments
Closed

[lock] add logging to ILock operations #11622

vertex-github opened this issue Oct 18, 2017 · 2 comments

Comments

@vertex-github
Copy link

@vertex-github vertex-github commented Oct 18, 2017

Currently ILock operations don't appear to be logged at any level. It would be very helpful if I could enable diagnostic log output, with the log line containing the name of the ILock, the operation (create, lock, unlock, destroy) and the usual timestamp, thread ID etc.

This would not only help diagnose locking problems (order of operations etc), but it would also help expose locks that are not being destroyed after use.

@vertex-github vertex-github changed the title Id like ILock lock/unlocks to be logged Id like ILock operations to be logged Oct 18, 2017
@mmedenjak mmedenjak added this to the 3.10 milestone Oct 18, 2017
@mmedenjak mmedenjak changed the title Id like ILock operations to be logged [lock] add logging to ILock operations Oct 18, 2017
blazember added a commit to blazember/hazelcast that referenced this issue Jan 9, 2018
Log at the finest level when locks are created, acquired, released or destroyed. Log messages added both before and after the operation with contextual information (success, requester, owner) where applicable.

Fixes hazelcast#11622
blazember added a commit to blazember/hazelcast that referenced this issue Jan 9, 2018
Log at the finest level when locks are created, acquired, released or destroyed. Log messages added both before and after the operation with contextual information (success, requester, owner) where applicable.

Fixes hazelcast#11622
blazember added a commit to blazember/hazelcast that referenced this issue Jan 9, 2018
Log at the finest level when locks are created, acquired, released or destroyed. Log messages added both before and after the operation with contextual information (success, requester, owner) where applicable.

Fixes hazelcast#11622
@blazember blazember self-assigned this Jan 9, 2018
blazember added a commit to blazember/hazelcast that referenced this issue Jan 10, 2018
Log at the finest level when locks are created, acquired, released or destroyed. Log messages added both before and after the operation with contextual information (success, requester, owner) where applicable.

Fixes hazelcast#11622
blazember added a commit to blazember/hazelcast that referenced this issue Jan 10, 2018
Log at the finest level when locks are created, acquired, released or destroyed. Log messages added both before and after the operation with contextual information (success, requester, owner) where applicable.

Fixes hazelcast#11622
blazember added a commit to blazember/hazelcast that referenced this issue Jan 10, 2018
Log at the finest level when locks are created, acquired, released or destroyed. Log messages added both before and after the operation with contextual information (success, requester, owner) where applicable.

Fixes hazelcast#11622
blazember added a commit to blazember/hazelcast that referenced this issue Jan 10, 2018
Log at the finest level when locks are created, acquired, released or destroyed. Log messages added both before and after the operation with contextual information (success, requester, owner) where applicable.

Fixes hazelcast#11622
blazember added a commit to blazember/hazelcast that referenced this issue Jan 11, 2018
Log at the finest level when locks are created, acquired, released or destroyed. Log messages added both before and after the operation with contextual information (success, requester, owner) where applicable.

Fixes hazelcast#11622
blazember added a commit to blazember/hazelcast that referenced this issue Jan 12, 2018
Log at the finest level when locks are created, acquired, released or destroyed. Log messages added both before and after the operation with contextual information (success, requester, owner) where applicable.

Fixes hazelcast#11622
blazember added a commit to blazember/hazelcast that referenced this issue Jan 15, 2018
Log at the finest level when locks are created, acquired, released or destroyed. Log messages added both before and after the operation with contextual information (success, requester, owner) where applicable.

Fixes hazelcast#11622
@IgnatBeresnev
Copy link

@IgnatBeresnev IgnatBeresnev commented Mar 28, 2019

Any hope you'll implement it for map-based locking? IMap.lock()

@mmedenjak
Copy link
Contributor

@mmedenjak mmedenjak commented Mar 28, 2019

@IgnatBeresnev no plans yet. Feel free to open a new issue for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants