Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMap aggregate, projection, localKeySet & executeOnEntries methods throws exception when PartitionPredicate used #11962

Closed
gokhanoner opened this issue Dec 11, 2017 · 2 comments

Comments

@gokhanoner
Copy link
Contributor

@gokhanoner gokhanoner commented Dec 11, 2017

See: https://github.com/hazelcast/hazelcast/blob/master/hazelcast/src/main/java/com/hazelcast/map/impl/proxy/MapProxyImpl.java#L797

A Partition predicate check can be added & query can be sent only that partition, This will also improve the performance of the aggregations. See Map.values with Predicate as an example: https://github.com/hazelcast/hazelcast/blob/master/hazelcast/src/main/java/com/hazelcast/map/impl/proxy/MapProxyImpl.java#L658

@gokhanoner gokhanoner self-assigned this Dec 11, 2017
@gokhanoner gokhanoner modified the milestones: 3.10, 3.9.2 Dec 11, 2017
@mmedenjak mmedenjak modified the milestones: 3.9.2, 3.9.3 Dec 19, 2017
@mmedenjak mmedenjak changed the title Map.aggregate with Predicate doesn't use PartitionPredicate improvements when called from a member instane Map.aggregate with Predicate doesn't use PartitionPredicate improvements when called from a member instance Jan 10, 2018
gokhanoner added a commit to gokhanoner/hazelcast that referenced this issue Jan 16, 2018
Added `PartitionPredicate` support to `localKeySet`, `aggregate`, `projection` & `executeOnEntries` methods on member side IMap implementation.
gokhanoner added a commit to gokhanoner/hazelcast that referenced this issue Jan 16, 2018
Added `PartitionPredicate` support to `localKeySet`, `aggregate`, `projection` & `executeOnEntries` methods on member side IMap implementation.
@gokhanoner gokhanoner changed the title Map.aggregate with Predicate doesn't use PartitionPredicate improvements when called from a member instance IMap aggregate, projection, localKeySet & executeOnEntries methods throws exception when PartitionPredicate used Jan 16, 2018
@tombujok
Copy link
Contributor

@tombujok tombujok commented Jan 16, 2018

It's all due to the fact how broken the process of implementing the PartitionPredicate was. I was against its design, and now we can also see how many holes it has...
CC @taburet It may be interesting for you.

@dimas
Copy link

@dimas dimas commented Apr 26, 2018

There is also #12238 which is very similar. Does this ticket cover it too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.