Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigXmlGeneratorTest - missing test for many attributes of multiple data structures #12119

Closed
tombujok opened this issue Jan 10, 2018 · 0 comments
Closed

Comments

@tombujok
Copy link
Contributor

@tombujok tombujok commented Jan 10, 2018

There are many data-structures missing in the ConfigXmlGeneratorTest.
This PR #12085 adds a unit test for each missing one, but it does not verify all missing attributes.
All these places are marked with a comment // TODO -> not full config checked

@tombujok tombujok added the Team: Core label Jan 10, 2018
@tombujok tombujok added this to the 3.10 milestone Jan 10, 2018
@taburet taburet added Team: Core and removed Team: Core labels Jan 22, 2018
@blazember blazember self-assigned this Jan 29, 2018
blazember added a commit to blazember/hazelcast that referenced this issue Jan 31, 2018
Many attributes for multiple data structures were missing in ConfigXmlGeneratorTest. This change adds them.
Also, some attributes and nodes were not generated before this change, those are added:
- Query caches in map config
- InitialMode in MapStore config
- SerializeKeys in NearCache config

To perform stricter validation in the tests, `equals()` and `hashCode()` methods are added to config classes where these were missing.

Fixes hazelcast#12119
blazember added a commit to blazember/hazelcast that referenced this issue Feb 1, 2018
Many attributes for multiple data structures were missing in ConfigXmlGeneratorTest.
Topic and reliable topic config generation was completely missing.
This change adds these missing parts.

Also, some attributes and nodes were not generated before this change, those are added:
- Query caches in map config
- InitialMode in MapStore config
- SerializeKeys in NearCache config

To perform stricter validation in the tests, `equals()` and `hashCode()` methods are added to config classes where these were missing.

Fixes hazelcast#12119
blazember added a commit to blazember/hazelcast that referenced this issue Feb 1, 2018
Many attributes for multiple data structures were missing in ConfigXmlGeneratorTest.
Topic and reliable topic config generation was completely missing.
This change adds these missing parts.

Also, some attributes and nodes were not generated before this change, those are added:
- Query caches in map config
- InitialMode in MapStore config
- SerializeKeys in NearCache config

To perform stricter validation in the tests, `equals()` and `hashCode()` methods are added to config classes where these were missing.

Fixes hazelcast#12119
blazember added a commit to blazember/hazelcast that referenced this issue Feb 1, 2018
Many attributes for multiple data structures were missing in ConfigXmlGeneratorTest.
Tests for topic and reliable topic config generation was completely missing along with non-datastructure related tests.
This change adds these missing parts.

All relevant branches of ConfigXmlGenerator are covered with tests.

Also, some attributes and nodes were not generated before this change, those are added:
- Query caches in map config
- InitialMode in MapStore config
- SerializeKeys in NearCache config

To perform stricter validation in the tests, `equals()` and `hashCode()` methods are added to config classes where these were missing.

Fixes hazelcast#12119
blazember added a commit to blazember/hazelcast that referenced this issue Feb 1, 2018
Many attributes for multiple data structures were missing in ConfigXmlGeneratorTest.
Tests for topic and reliable topic config generation was completely missing along with non-datastructure related tests.
This change adds these missing parts.

All relevant branches of ConfigXmlGenerator are covered with tests.

Also, some attributes and nodes were not generated before this change, those are added:
- Query caches in map config
- InitialMode in MapStore config
- SerializeKeys in NearCache config

To perform stricter validation in the tests, `equals()` and `hashCode()` methods are added to config classes where these were missing.

Fixes hazelcast#12119
blazember added a commit to blazember/hazelcast that referenced this issue Feb 2, 2018
Many attributes for multiple data structures were missing in ConfigXmlGeneratorTest.
Tests for topic and reliable topic config generation was completely missing along with non-datastructure related tests.
This change adds these missing parts.

All relevant branches of ConfigXmlGenerator are covered with tests.

Also, some attributes and nodes were not generated before this change, those are added:
- Query caches in map config
- InitialMode in MapStore config
- SerializeKeys in NearCache config

To perform stricter validation in the tests, `equals()` and `hashCode()` methods are added to config classes where these were missing.

Fixes hazelcast#12119
blazember added a commit to blazember/hazelcast that referenced this issue Feb 2, 2018
Many attributes for multiple data structures were missing in ConfigXmlGeneratorTest.
Tests for topic and reliable topic config generation was completely missing along with non-datastructure related tests.
This change adds these missing parts.

All relevant branches of ConfigXmlGenerator are covered with tests.

Also, some attributes and nodes were not generated before this change, those are added:
- Query caches in map config
- InitialMode in MapStore config
- SerializeKeys in NearCache config

To perform stricter validation in the tests, `equals()` and `hashCode()` methods are added to config classes where these were missing.

Fixes hazelcast#12119
blazember added a commit that referenced this issue Feb 2, 2018
Test attribute generation in ConfigXmlGeneratorTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.