Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Dynamic MapConfig From HazelcastClient omits timeToLiveSeconds value #12273

Closed
skwangh opened this issue Feb 7, 2018 · 3 comments
Closed

Comments

@skwangh
Copy link

@skwangh skwangh commented Feb 7, 2018

When using HazelcastClient instance to add dynamic MapConfig, It generally works for most of other parameters but timeToLiveSeconds parameter is always 0.

I found getConfig() method in com.hazelcast.client.impl.protocol.task.dynamicconfig.AddMapConfigMessageTask class
is called by hazelcast cluster when I add dynamic MapConfig from client, but there is no code for timeToLiveSeconds.

Is it intended?

Hazelcast version : 3.9.2
Cluster size : 1
Number of the clients : 1 (seperated from cluster)
Version of Java : JDK 1.8
Operating system : Windows10 (for development)
Logs and stack traces : N/A
Detailed description of the steps to reproduce your issue :

  1. Run cluster with default config.
  2. Run client and add dynamic MapConfig with some customized timeToLiveSeconds value using HazelcastClient instance
    ex) hazelcastClient.getConfig().addMapConfig(mapConfig);
  3. Check config is added
    ex) hazelcastClient.getConfig().getMapConfigs();
  4. You can see mapConfig is added but timeToLiveSeconds is 0
    Unit test with the hazelcast.xml file : N/A
    integration module versions : Spring Boot 1.5.6 with embedded tomcat
@vbekiaris
Copy link
Contributor

@vbekiaris vbekiaris commented Feb 7, 2018

@skwangh this sounds like an omission, thanks for the awesome issue report. The fix should be pretty easy, we just need to transfer the timeToLiveSeconds value from parameters to the Config in AddMapConfigMessageTask as you noticed and add timeToLiveSeconds in the MapConfig used in the related tests. Fancy preparing a pull request?

@skwangh
Copy link
Author

@skwangh skwangh commented Feb 8, 2018

@vbekiaris , @mumukiller Thanks for your kindness and greate job! :)

@vbekiaris
Copy link
Contributor

@vbekiaris vbekiaris commented Feb 13, 2018

Fixed by #12276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.