Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split-brain merge policy config validation is wrong #12722

Closed
Donnerbart opened this issue Mar 27, 2018 · 0 comments
Closed

Split-brain merge policy config validation is wrong #12722

Donnerbart opened this issue Mar 27, 2018 · 0 comments

Comments

@Donnerbart
Copy link
Contributor

@Donnerbart Donnerbart commented Mar 27, 2018

The merge policy checks in ConfigValidator are based on false assumptions regarding SomeConfig.isStatisticsEnabled() and valid split-brain merge types. The MergingHits capability doesn't depend on enabled statistics, just on the data structure. There are just two merge types for IMap, which depend on the statistics configuration (MergingLastStoredTime and MergingExpirationTime).

The current implementation also doesn't work for custom merge policies, since it only checks our out-of-the-box merge policies.

We should rely on the required and provided merge types of #12721 to implement a proper solution for the config validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.