Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE on AbstractMessageTask.getClientVersion #13119

Closed
sancar opened this issue May 17, 2018 · 0 comments
Closed

NPE on AbstractMessageTask.getClientVersion #13119

sancar opened this issue May 17, 2018 · 0 comments

Comments

@sancar
Copy link
Member

@sancar sancar commented May 17, 2018

from this run https://hazelcast-l337.ci.cloudbees.com/view/split/job/split-data-loss-multi-v/10/console
using 3.9.4 3.10.2-SNAPSHOT ( vassilis branch) a multi version split brain test

SEVERE: [10.0.0.221]:5701 [HZ] [3.9.4] Failed asynchronous execution of execution callback: com.hazelcast.client.impl.protocol.task.cache.CacheCreateConfigMessageTask@4f6b92f5for ca
ll Invocation{op=com.hazelcast.cache.impl.operation.CacheCreateConfigOperation{serviceName='hz:impl:cacheService', identityHash=528300943, partitionId=39, replicaIndex=0, callId=-81
29, invocationTime=1526519702720 (2018-05-17 01:15:02.720), waitTimeout=-1, callTimeout=60000, name=/hz/cacheBak1_data-loss}, tryCount=250, tryPauseMillis=500, invokeCount=1, callTi
meoutMillis=60000, firstInvocationTimeMs=1526519702718, firstInvocationTime='2018-05-17 01:15:02.718', lastHeartbeatMillis=0, lastHeartbeatTime='1970-01-01 00:00:00.000', target=[10
.0.0.221]:5701, pendingResponse={VOID}, backupsAcksExpected=0, backupsAcksReceived=0, connection=null}
java.lang.NullPointerException
    at com.hazelcast.client.impl.protocol.task.AbstractMessageTask.getClientVersion(AbstractMessageTask.java:79)
    at com.hazelcast.client.impl.protocol.task.cache.AbstractCacheMessageTask.serializeCacheConfig(AbstractCacheMessageTask.java:79)
    at com.hazelcast.client.impl.protocol.task.cache.CacheCreateConfigMessageTask.encodeResponse(CacheCreateConfigMessageTask.java:77)
    at com.hazelcast.client.impl.protocol.task.AbstractMessageTask.sendResponse(AbstractMessageTask.java:198)
    at com.hazelcast.client.impl.protocol.task.AbstractPartitionMessageTask.onResponse(AbstractPartitionMessageTask.java:89)
    at com.hazelcast.spi.impl.AbstractInvocationFuture$1.run(AbstractInvocationFuture.java:248)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1152)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:622)
    at java.lang.Thread.run(Thread.java:748)
    at com.hazelcast.util.executor.HazelcastManagedThread.executeRun(HazelcastManagedThread.java:64)
    at com.hazelcast.util.executor.HazelcastManagedThread.run(HazelcastManagedThread.java:80)
@sancar sancar added this to the 3.10.2 milestone May 17, 2018
@sancar sancar self-assigned this May 17, 2018
sancar added a commit to sancar/hazelcast that referenced this issue May 18, 2018
getEndpoint is renamed to initEndpoint to make it clearer that
it should not be called besides the constructor.

All accesses to endpoint is made via `endpoint` field instead of
`getEndpoint` method.

`endpoint` field being null is already handled in
AbstractMessageTask.run. And it is quaranteed to be non-null for
any MessageTask .

fixes hazelcast#13119
sancar added a commit to sancar/hazelcast that referenced this issue May 18, 2018
getEndpoint is renamed to initEndpoint to make it clearer that
it should not be called besides the constructor.

All accesses to endpoint is made via `endpoint` field instead of
`getEndpoint` method.

`endpoint` field being null is already handled in
AbstractMessageTask.run. And it is quaranteed to be non-null for
any MessageTask .

fixes hazelcast#13119

(cherry picked from commit 7edfd21)
sancar added a commit to sancar/hazelcast that referenced this issue May 21, 2018
getEndpoint is renamed to initEndpoint to make it clearer that
it should not be called besides the constructor.

All accesses to endpoint is made via `endpoint` field instead of
`getEndpoint` method.

`endpoint` field being null is already handled in
AbstractMessageTask.run. And it is quaranteed to be non-null for
any MessageTask .

fixes hazelcast#13119
sancar added a commit to sancar/hazelcast that referenced this issue May 21, 2018
All accesses to endpoint is made via `endpoint` field instead of
`getEndpoint` method.

make initEndpoint private.

endpoint can't be null. It can only be authenticated/not authenticated.

AuthenticationBaseMessageTask is allowed to run on non-authenticated
endpoint as before.

fixes hazelcast#13119
sancar added a commit to sancar/hazelcast that referenced this issue May 22, 2018
All accesses to endpoint is made via `endpoint` field instead of
`getEndpoint` method.

make initEndpoint private.

endpoint can't be null. It can only be authenticated/not authenticated.

AuthenticationBaseMessageTask is allowed to run on non-authenticated
endpoint as before.

fixes hazelcast#13119

(cherry picked from commit f9eebab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.