Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding data structure config at runtime fails when same config exists as static config #13158

Closed
vbekiaris opened this issue May 21, 2018 · 0 comments

Comments

@vbekiaris
Copy link
Contributor

@vbekiaris vbekiaris commented May 21, 2018

When adding a dynamic data structure configuration then we fail-fast when the same structure is already configured statically. even when both configs are equal.
The expected outcome would be to silently ignore the submitted dynamic config when it is equal to an existing static config, or fail with a ConfigurationException when a conflicting static config already exists. The same behavior (ignore when equal, fail on conflict) is already in place when checking a submitted config against existing dynamic configs.

Kudos @jerrinot for raising this issue

@vbekiaris vbekiaris added this to the 3.11 milestone May 21, 2018
vbekiaris added a commit that referenced this issue Aug 7, 2018
#13453)

* Adding data structure config at runtime should not fail
unless unequal config exists as static config #13158
* Do not broadcast new config if same config exists already
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.