Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in predicate implementations do not implement equals/hashCode #13245

Closed
vbekiaris opened this issue Jun 5, 2018 · 3 comments
Closed

Built-in predicate implementations do not implement equals/hashCode #13245

vbekiaris opened this issue Jun 5, 2018 · 3 comments

Comments

@vbekiaris
Copy link
Contributor

@vbekiaris vbekiaris commented Jun 5, 2018

The predicate implementations can be compared for equality based on their fields' values. Additionally, not having equals implementation makes it hard to test those classes. Leftover from #13242.

@webashutosh
Copy link
Contributor

@webashutosh webashutosh commented Jun 19, 2018

@vbekiaris I just added a commit to implement the methods. I am a first-time committer to this repo and I am very keen on contributing more. Could you please let me know of any review comments?

@vbekiaris
Copy link
Contributor Author

@vbekiaris vbekiaris commented Jun 19, 2018

@webashutosh that's awesome! As a first time contributor, you need to sign the contributor agreement (see here for instructions). I'll post my review comments on the pull request. Thanks!

Donnerbart added a commit that referenced this issue Jun 28, 2018
… (#13318)

Implemented equals() and hashCode() methods for built-in predicate implementations
@taburet
Copy link
Contributor

@taburet taburet commented Jul 5, 2018

Implemented in #13318 , closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.