Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hazelcast-hibernate versions in hazelcast-all artifact #13250

Closed
cool-mist opened this issue Jun 5, 2018 · 4 comments
Closed

Fix hazelcast-hibernate versions in hazelcast-all artifact #13250

cool-mist opened this issue Jun 5, 2018 · 4 comments

Comments

@cool-mist
Copy link

@cool-mist cool-mist commented Jun 5, 2018

When using hazelcast-all artifact (3.10.1), the version of hazelcast-hibernate included within is the one built using hibernate-3.
Reference : https://github.com/hazelcast/hazelcast/blob/master/hazelcast-all/pom.xml#L164-L166

Ask : Provide a way for applications to exclude this and include a different version of hazelcast-hibernate (hazelcast-hibernate4 or hazelcast-hibernate5x etc) even when using hazelcast-all or hazelcast-enterprise-all jar.

Also, does it make sense to remove this artifact from hazelcast-all as the correct artifact to be included would depend on the hibernate version present in the application project?

@mmedenjak mmedenjak changed the title FIx hazelcast-hibernate versions in hazelcast-all artifact Fix hazelcast-hibernate versions in hazelcast-all artifact Jun 5, 2018
@mmedenjak mmedenjak added this to the 3.11 milestone Jun 5, 2018
@jbee jbee self-assigned this Sep 13, 2018
@mesutcelik
Copy link
Contributor

@mesutcelik mesutcelik commented Sep 13, 2018

We need to update hazelcast-hibernate integration version in the following parts of the codebase

  1. replace hibernate3 in hazelcast-all shade plugin
  2. introduce pre-hibernate52 into hazelcast-spring modules because hibernate 5.2 does require java8.

@jerrinot , @jbee
If you have more comments, it would be appreciated...

@jerrinot
Copy link
Contributor

@jerrinot jerrinot commented Sep 24, 2018

@mesutcelik: agree. please send the PR. thanks!

@mesutcelik
Copy link
Contributor

@mesutcelik mesutcelik commented Sep 24, 2018

@jbee will take care of it.

@jerrinot
Copy link
Contributor

@jerrinot jerrinot commented Oct 5, 2018

fixed by #13861

@jerrinot jerrinot closed this Oct 5, 2018
@mmedenjak mmedenjak removed the To Triage label Mar 29, 2019
@mmedenjak mmedenjak removed the To Triage label Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.