Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HazelcastClient JavaDoc should use "unicast client" instead of "dumb client" #14213

Closed
jerrinot opened this issue Dec 4, 2018 · 5 comments
Closed

Comments

@jerrinot
Copy link
Contributor

@jerrinot jerrinot commented Dec 4, 2018

See: https://github.com/jerrinot/hazelcast/blob/3438e05a2e8e8a1ac21b9f92798d55ae3b9a9f78/hazelcast-client/src/main/java/com/hazelcast/client/HazelcastClient.java#L33

 * <h1>Smart vs dumb clients</h1>
 * Hazelcast Client enables you to do all Hazelcast operations without being a member of the cluster. Clients can be:
 * <ol>
 * <li>smart: this means that they immediately can send an operation like map.get(key) to the member that owns that
 * specific key.
 * </li>
 * <li>
 * dumb: it will connect to a random member in the cluster and send requests to this member. This member then needs
 * to send the request to the correct member.
@jerrinot jerrinot added this to the 3.12 milestone Dec 4, 2018
@jerrinot jerrinot changed the title HazelcastClient JavaDoc should use "unicast client" instead of "dump client" HazelcastClient JavaDoc should use "unicast client" instead of "dumb client" Dec 4, 2018
@tezc
Copy link
Contributor

@tezc tezc commented Dec 5, 2018

Loading

@sancar
Copy link
Member

@sancar sancar commented Dec 5, 2018

@jerrinot We were calling this unisocket client, not unicast . Is there a change in the name that I missed ?

Loading

@jerrinot
Copy link
Contributor Author

@jerrinot jerrinot commented Dec 5, 2018

@sancar: no, I was just having a blackout:) of course it should be unisocket. thanks for spotting this.
@tezc: well spotted, I believe we should consistently use the unisocket term at all places.

Loading

@sancar sancar self-assigned this Dec 5, 2018
@sancar
Copy link
Member

@sancar sancar commented Dec 5, 2018

I will fix the javadocs with this pr. I have also opened an issue in the reference manual to keep track of the issue.
hazelcast/hazelcast-reference-manual#620

Loading

@sancar sancar closed this in f02626a Dec 5, 2018
@sancar
Copy link
Member

@sancar sancar commented Dec 5, 2018

fixed by f02626a

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants