Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail-fast if max-idle-seconds is set below 2 seconds #14697

Closed
yozank opened this issue Mar 14, 2019 · 3 comments

Comments

Projects
None yet
5 participants
@yozank
Copy link
Contributor

commented Mar 14, 2019

As part of /pull/13320, any access to entries within a second will be rounded to 0.
So, if the entry has 1 second of max-idle-seconds, any access will not be counted and it will expire after 1 second.
It should fail-fast with an explanation if there is a 1-sec max-idle-seconds setting.

@burakcelebi

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

cc: @tkountis

@tkountis

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

Let me clarify this one a bit more.
Due to the loss of millisecond resolution on the Record timestamps (LUT, LAT, LST etc) when you create a record at time=1s (no MS info), and access it at wall-clock time 1.1 (includes 100ms) and then at wall-clock time 1.4 (includes 400ms) the timestamps get updated only with the second part of the wall-clock time, i.e., 1s (no MS info, again). In other words, it behaves as if the record was not touched.
Therefore, setting a max-idle to 1second will expire the record after 1 second, regardless of operations done on that same record in-between.

A max-idle of 1 second, is fairly unreasonable to have, but nevertheless, we should fail-fast as per @yozank suggestion, to avoid surprises.

@mmedenjak

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

Moving to 3.13 as it is not critical to the release. We may fix this once other more important issues are addressed.

@mmedenjak mmedenjak modified the milestones: 3.12, 3.13 Mar 14, 2019

@galibey galibey self-assigned this Mar 19, 2019

galibey added a commit to galibey/hazelcast that referenced this issue Mar 21, 2019

@mmedenjak mmedenjak modified the milestones: 3.13, 3.12 Mar 26, 2019

galibey added a commit that referenced this issue Mar 27, 2019

Fail-fast if max-idle-seconds is set below 2 seconds (#14727)
* Fail-fast if max-idle-seconds is set below 2 seconds

Fixes: #14697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.