Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HazelcastServerCachingProvider.createCachingProvider package-private #15144

Closed
vbekiaris opened this issue Jun 10, 2019 · 0 comments · Fixed by #15890
Closed

Make HazelcastServerCachingProvider.createCachingProvider package-private #15144

vbekiaris opened this issue Jun 10, 2019 · 0 comments · Fixed by #15890

Comments

@vbekiaris
Copy link
Contributor

@vbekiaris vbekiaris commented Jun 10, 2019

Even though HazelcastServerCachingProvider is in impl package (therefore private API), the static method createCachingProvider is public. Usage of this method is dangerous in production code because it always creates & returns a new CachingProvider, which is almost always the wrong thing to do in production code. Instead, production code that needs to obtain a CachingProvider should use the JCache-standard way Caching.getCachingProvider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.