Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception thrown from a dynamic metric provider stops the collector task #15932

Closed
blazember opened this issue Nov 5, 2019 · 0 comments · Fixed by #15933
Closed

Exception thrown from a dynamic metric provider stops the collector task #15932

blazember opened this issue Nov 5, 2019 · 0 comments · Fixed by #15933

Comments

@blazember
Copy link
Contributor

@blazember blazember commented Nov 5, 2019

If the dynamic metrics collection encounters an exception it bubbles the exception up to the caller triggered the collection. This is a periodically scheduled task that is getting stopped once it is hit by an exception. Therefore, the exceptions should be caught and logged, but not propagated.

This is found by throwing an NPE from TcpIpNetworkingService in advanced networking mode, in which case its field unifiedEndpointManager is null.

@blazember blazember added this to the 4.0 milestone Nov 5, 2019
@blazember blazember self-assigned this Nov 5, 2019
blazember added a commit to blazember/hazelcast that referenced this issue Nov 5, 2019
If the dynamic metrics collection encounters an exception it bubbles the
exception up to the caller triggered the periodic task that triggered
the collection. It is fixed by catching and logging the exception
without bubbling it up.

Throwing an NPE from
`TcpIpNetworkingService.MetricsProvider#provideDynamicMetrics` in
advanced networking mode is fixed by adding a null check around
`unifiedEndpointManager`.

Fixes hazelcast#15932
blazember added a commit that referenced this issue Nov 6, 2019
If the dynamic metrics collection encounters an exception it bubbles the
exception up to the caller triggered the periodic task that triggered
the collection. It is fixed by catching and logging the exception
without bubbling it up.

Throwing an NPE from
`TcpIpNetworkingService.MetricsProvider#provideDynamicMetrics` in
advanced networking mode is fixed by adding a null check around
`unifiedEndpointManager`.

Fixes #15932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.